Implement new dangerous download reporting dialog for UNCOMMON_DOWNLOAD, in Views

chrome/browser/ui/views/download/download_shelf_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_SHELF_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_SHELF_VIEW_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "chrome/browser/download/download_shelf.h"
+#include "chrome/browser/ui/views/frame/browser_view.h"
 #include "ui/gfx/animation/animation_delegate.h"
 #include "ui/views/accessible_pane_view.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/link_listener.h"
 #include "ui/views/mouse_watcher.h"
 
 class Browser;
-class BrowserView;
 class DownloadItemView;
 
 namespace content {
 class DownloadItem;
 class PageNavigator;
 }
 
 namespace gfx {
 class SlideAnimation;
 }
@@ skipping 16 matching lines @@
                           public views::MouseWatcherListener {
  public:
   DownloadShelfView(Browser* browser, BrowserView* parent);
   virtual ~DownloadShelfView();
 
   // Sent from the DownloadItemView when the user opens an item.
   void OpenedDownload(DownloadItemView* view);
 
   // Returns the relevant containing object that can load pages.
   // i.e. the |browser_|.
   content::PageNavigator* GetNavigator();

[Peter Kasting, 2014/02/04 21:56:33]

Nit: While here: There's no need for this function.  All callers can just call
browser() instead, which is also public.  Nuke this.

Note: If this comment and/or the last one in this file would result in large
diffs, feel free to do them as separate CLs.

[felt, 2014/02/04 23:37:22]

I'll send a follow-up CL for this.

 
+  // Returns the parent_.
+  BrowserView* GetParentWindowView();

[Peter Kasting, 2014/02/04 21:56:33]

Nit: This function should be inlined and named like:

  BrowserView* get_parent() { return parent_; }

[felt, 2014/02/04 23:37:22]

Done.

+
   // Implementation of View.
   virtual gfx::Size GetPreferredSize() OVERRIDE;
   virtual void Layout() OVERRIDE;
   virtual void ViewHierarchyChanged(
       const ViewHierarchyChangedDetails& details) OVERRIDE;
 
   // Implementation of gfx::AnimationDelegate.
   virtual void AnimationProgressed(const gfx::Animation* animation) OVERRIDE;
   virtual void AnimationEnded(const gfx::Animation* animation) OVERRIDE;
 
   // Implementation of views::LinkListener.
   // Invoked when the user clicks the 'show all downloads' link button.
   virtual void LinkClicked(views::Link* source, int event_flags) OVERRIDE;
 
   // Implementation of ButtonListener.
   // Invoked when the user clicks the close button. Asks the browser to
   // hide the download shelf.
   virtual void ButtonPressed(views::Button* button,
                              const ui::Event& event) OVERRIDE;
 
   // Implementation of DownloadShelf.
   virtual bool IsShowing() const OVERRIDE;
   virtual bool IsClosing() const OVERRIDE;
   virtual Browser* browser() const OVERRIDE;

[Peter Kasting, 2014/02/04 21:56:33]

Nit: While here: Virtual functions must never be named unix_hacker()-style. 
Capitalize this (and in the remainder of the class hierarchy).

[felt, 2014/02/04 23:37:22]

I'll send a follow-up CL for this.

 
   // Implementation of MouseWatcherListener OVERRIDE.
   virtual void MouseMovedOutOfHost() OVERRIDE;
 
   // Removes a specified download view. The supplied view is deleted after
   // it's removed.
   void RemoveDownloadView(views::View* view);
 
  protected:
   // Implementation of DownloadShelf.
@@ skipping 55 matching lines @@
 
   // The window this shelf belongs to.
   BrowserView* parent_;
 
   views::MouseWatcher mouse_watcher_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadShelfView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_SHELF_VIEW_H_