Implement new dangerous download reporting dialog for UNCOMMON_DOWNLOAD, in Views

chrome/browser/ui/views/download/download_item_view.h

Index: chrome/browser/ui/views/download/download_item_view.h
diff --git a/chrome/browser/ui/views/download/download_item_view.h b/chrome/browser/ui/views/download/download_item_view.h
index a1c34b18c59882fa9c0858890a865112c773c97f..9f86a20225b958417d01dde01a90b2b63026b18c 100644
--- a/chrome/browser/ui/views/download/download_item_view.h
+++ b/chrome/browser/ui/views/download/download_item_view.h
@@ -151,6 +151,10 @@ class DownloadItemView : public views::ButtonListener,
   // false is returned, nothing has changed.

[Peter Kasting, 2014/02/04 21:56:33]

Nit: While here, maybe change to:

Submits the downloaded file to the safebrowsing download feedback service. 
Returns whether submission was successful.  On successful submission, |this| and
the DownloadItem will have been deleted.

[felt, 2014/02/04 23:37:22]

Done.

   bool BeginDownloadFeedback();

[Peter Kasting, 2014/02/04 21:56:33]

Nit: This function name and the one below seem somewhat confusing.  What about:

  bool SubmitDownloadToFeedbackService();

and

  void PossiblySubmitDownloadToFeedbackService();

?

[felt, 2014/02/04 23:37:22]

Done.

 
+  // If the user has enabled uploading, calls BeginDownloadFeedback. Otherwise,
+  // it simply removes the DownloadItem without uploading.
+  void BeginDownloadFeedbackWrapper(bool user_enabled);

[Peter Kasting, 2014/02/04 21:56:33]

Nit: Header declaration order does not mach .cc definition order

[felt, 2014/02/04 23:37:22]

Done.

+
   void LoadIcon();
   void LoadIconIfItemPathChanged();