Implement new dangerous download reporting dialog for UNCOMMON_DOWNLOAD, in Views

chrome/browser/ui/views/download/download_item_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A ChromeView that implements one download on the Download shelf.
 // Each DownloadItemView contains an application icon, a text label
 // indicating the download's file name, a text label indicating the
 // download's status (such as the number of bytes downloaded so far)
 // and a button for canceling an in progress download, or opening
 // the completed download.
@@ skipping 130 matching lines @@
   struct DropDownImageSet {
     gfx::ImageSkia* top;
     gfx::ImageSkia* center;
     gfx::ImageSkia* bottom;
   };
 
   void OpenDownload();
 
   // Submit the downloaded file to the safebrowsing download feedback service.
   // If true is returned, the DownloadItem and |this| have been deleted.  If
   // false is returned, nothing has changed.

[Peter Kasting, 2014/02/04 21:56:33]

Nit: While here, maybe change to:

Submits the downloaded file to the safebrowsing download feedback service. 
Returns whether submission was successful.  On successful submission, |this| and
the DownloadItem will have been deleted.

[felt, 2014/02/04 23:37:22]

Done.

   bool BeginDownloadFeedback();

[Peter Kasting, 2014/02/04 21:56:33]

Nit: This function name and the one below seem somewhat confusing.  What about:

  bool SubmitDownloadToFeedbackService();

and

  void PossiblySubmitDownloadToFeedbackService();

?

[felt, 2014/02/04 23:37:22]

Done.

 
+  // If the user has enabled uploading, calls BeginDownloadFeedback. Otherwise,
+  // it simply removes the DownloadItem without uploading.
+  void BeginDownloadFeedbackWrapper(bool user_enabled);

[Peter Kasting, 2014/02/04 21:56:33]

Nit: Header declaration order does not mach .cc definition order

[felt, 2014/02/04 23:37:22]

Done.

+
   void LoadIcon();
   void LoadIconIfItemPathChanged();
 
   // Update the button colors based on the current theme.
   void UpdateColorsFromTheme();
 
   // Shows the context menu at the specified location. |point| is in the view's
   // coordinate system.
   void ShowContextMenuImpl(const gfx::Point& point,
                            ui::MenuSourceType source_type);
@@ skipping 168 matching lines @@
 
   // The icon loaded in the download shelf is based on the file path of the
   // item.  Store the path used, so that we can detect a change in the path
   // and reload the icon.
   base::FilePath last_download_item_path_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadItemView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_ITEM_VIEW_H__