Issue 14759026: Android: Disable 'sincos' optimization to avoid 'icu' link errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14759026: Android: Disable 'sincos' optimization to avoid 'icu' link errors. (Closed)

Created:
7 years, 7 months ago by Yaron

Modified:
7 years, 7 months ago

Reviewers:
cjhopman, digit1

CC:
cjhopman

Base URL:
http://src.chromium.org/svn/trunk/deps/third_party/icu46

Visibility:
Public.

More Reviews

Description

Android: Disable 'sincos' optimization to avoid 'icu' link errors. This started failing with the roll to Android NDK r8e. This only happens with the component build, presumably because in the regular build this code is optimized out. BUG=237460 R=cjhopman@chromium.org Committed: 199252

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	icu.gyp	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yaron

Chris: care to stamp? Looks like digit didn't get to this and it'd be nice ...

7 years, 7 months ago (2013-05-09 18:18:36 UTC) #2

Yaron

7 years, 7 months ago (2013-05-09 19:03:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r199252 (presubmit successful).

Expand Messages | Collapse Messages