Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: icu.gyp

Issue 14759026: Android: Disable 'sincos' optimization to avoid 'icu' link errors. (Closed) Base URL: http://src.chromium.org/svn/trunk/deps/third_party/icu46
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: icu.gyp
diff --git a/icu.gyp b/icu.gyp
index 3236307b88b252e47722cfeaab3482833b09e1ea..d86003c5350a7295973f9f18aaa139595fd12f53 100644
--- a/icu.gyp
+++ b/icu.gyp
@@ -319,6 +319,14 @@
'-Wno-return-type-c-linkage',
],
}],
+ ['OS == "android" and clang==0', {
+ # Disable sincos() optimization to avoid a linker error since
+ # Android's math library doesn't have sincos(). Either
+ # -fno-builtin-sin or -fno-builtin-cos works.
+ 'cflags': [
+ '-fno-builtin-sin',
+ ],
+ }],
['OS == "android" and use_system_stlport == 1', {
# ICU requires RTTI, which is not present in the system's stlport,
# so we have to include gabi++.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698