Docserver: fix SubversionFileSystem

Docserver: fix bug where SubversionFileSystem was returning the wrong Stat data
for files.

R=yoz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198208

[not at google - send to devlin, 2013-05-03 19:48:13]

Hey yoz can you review this, clark is away.

[Yoyo Zhou, 2013-05-03 20:01:24]

https://codereview.chromium.org/14759009/diff/2001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/subversion_file_system.py (right):

https://codereview.chromium.org/14759009/diff/2001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/subversion_file_system.py:122: directory,
filename = path.rsplit('/', 1)
How about os.path.dirname and os.path.basename?

[not at google - send to devlin, 2013-05-03 20:41:25]

https://codereview.chromium.org/14759009/diff/2001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/subversion_file_system.py (right):

https://codereview.chromium.org/14759009/diff/2001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/subversion_file_system.py:122: directory,
filename = path.rsplit('/', 1)
On 2013/05/03 20:01:24, Yoyo Zhou wrote:
> How about os.path.dirname and os.path.basename?

Except these are URLs not paths, so needs to be explicitly splitting with '/'.

[Yoyo Zhou, 2013-05-03 20:52:47]

https://codereview.chromium.org/14759009/diff/2001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/subversion_file_system.py (right):

https://codereview.chromium.org/14759009/diff/2001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/subversion_file_system.py:122: directory,
filename = path.rsplit('/', 1)
On 2013/05/03 20:41:25, kalman wrote:
> On 2013/05/03 20:01:24, Yoyo Zhou wrote:
> > How about os.path.dirname and os.path.basename?
> 
> Except these are URLs not paths, so needs to be explicitly splitting with '/'.

The os.path functions seem to work just fine on URLs.

[not at google - send to devlin, 2013-05-03 21:06:49]

https://codereview.chromium.org/14759009/diff/2001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/subversion_file_system.py (right):

https://codereview.chromium.org/14759009/diff/2001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/subversion_file_system.py:122: directory,
filename = path.rsplit('/', 1)
On 2013/05/03 20:52:47, Yoyo Zhou wrote:
> On 2013/05/03 20:41:25, kalman wrote:
> > On 2013/05/03 20:01:24, Yoyo Zhou wrote:
> > > How about os.path.dirname and os.path.basename?
> > 
> > Except these are URLs not paths, so needs to be explicitly splitting with
'/'.
> 
> The os.path functions seem to work just fine on URLs.

did you test on windows?

[not at google - send to devlin, 2013-05-03 21:28:01]

posixpath is handy.

[Yoyo Zhou, 2013-05-03 21:29:41]

LGTM

[not at google - send to devlin, 2013-05-03 22:13:32]

Committed patchset #3 manually as r198208 (presubmit successful).