Docserver: fix SubversionFileSystem

chrome/common/extensions/docs/server2/subversion_file_system.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from file_system import FileSystem, FileNotFoundError, StatInfo, ToUnicode
 from future import Future
 import logging
 import re
 import xml.dom.minidom as xml
 from xml.parsers.expat import ExpatError
@@ skipping 100 matching lines @@
       # All versions in StatInfo need to be strings.
       return StatInfo(str(parent_version),
                       dict((path, str(version))
                            for path, version in child_versions.iteritems()))
 
     # Bleh, but, this data is so unreliable. There are actually some empty file
     # listings caused by git/svn/something not cleaning up empty dirs.
     return StatInfo('0', {})
 
   def Stat(self, path):
-    directory = path.rsplit('/', 1)[0]
+    if '/' in path:
+      directory, filename = path.rsplit('/', 1)

[Yoyo Zhou, 2013/05/03 20:01:24]

How about os.path.dirname and os.path.basename?

[not at google - send to devlin, 2013/05/03 20:41:25]

Except these are URLs not paths, so needs to be explicitly splitting with '/'.

[Yoyo Zhou, 2013/05/03 20:52:47]

The os.path functions seem to work just fine on URLs.

[not at google - send to devlin, 2013/05/03 21:06:49]

did you test on windows?

+    else:
+      directory, filename = ('', path)
     result = self._stat_fetcher.Fetch(directory + '/')
     if result.status_code == 404:
       raise FileNotFoundError(
           'Got 404 when fetching %s from %s for Stat' % (path, directory))
     stat_info = self._CreateStatInfo(result.content)
-    if not path.endswith('/'):
-      filename = path.rsplit('/', 1)[-1]
-      if filename not in stat_info.child_versions:
-        raise FileNotFoundError('%s was not in child versions' % filename)
-      stat_info.version = stat_info.child_versions[filename]
-    return stat_info
+    if path.endswith('/'):
+      return stat_info
+    if filename not in stat_info.child_versions:
+      raise FileNotFoundError('%s was not in child versions' % filename)
+    return StatInfo(stat_info.child_versions[filename])