Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1475843004: Ignore View visibility for WebView's page visibility API. (Closed)

Created:
5 years ago by hush (inactive)
Modified:
5 years ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore View visibility for WebView's page visibility API. Some apps will still try to draw on an invisible WebView, like taking snapshot into a bitmap etc. In order not to break these apps, WebView will ignore view visibility for blink page visibility API. So now, if an app wants to toggle blink page visibility, it has to call WebView#onPause/onResume. The visibility of the window that the WebView is attached to is not under control of the app. BUG=561706 Committed: https://crrev.com/b31ed632eb9740847de0e2ab3489f7c4b0d96e54 Cr-Commit-Position: refs/heads/master@{#361802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M android_webview/browser/browser_view_renderer.cc View 3 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
hush (inactive)
Hi Selim, PTAL
5 years ago (2015-11-25 21:57:15 UTC) #2
sgurun-gerrit only
lgtm
5 years ago (2015-11-25 23:01:12 UTC) #3
sgurun-gerrit only
On 2015/11/25 23:01:12, sgurun wrote: > lgtm don't forget to write a test in a ...
5 years ago (2015-11-25 23:01:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475843004/1
5 years ago (2015-11-25 23:21:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years ago (2015-11-26 01:31:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475843004/1
5 years ago (2015-11-26 01:35:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 02:40:50 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-26 02:41:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b31ed632eb9740847de0e2ab3489f7c4b0d96e54
Cr-Commit-Position: refs/heads/master@{#361802}

Powered by Google App Engine
This is Rietveld 408576698