Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1548)

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 1475843004: Ignore View visibility for WebView's page visibility API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/browser_view_renderer.cc
diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc
index fa9ea172dc883e145060c237771bcb75d6cb64ea..6f3ecd503c702d89f4ae1eaf7f494f5f6fefd351 100644
--- a/android_webview/browser/browser_view_renderer.cc
+++ b/android_webview/browser/browser_view_renderer.cc
@@ -378,8 +378,6 @@ void BrowserViewRenderer::SetViewVisibility(bool view_visible) {
"view_visible",
view_visible);
view_visible_ = view_visible;
- if (!disable_page_visibility_)
- UpdateCompositorIsActive();
}
void BrowserViewRenderer::SetWindowVisibility(bool window_visible) {
@@ -452,7 +450,7 @@ bool BrowserViewRenderer::IsClientVisible() const {
if (disable_page_visibility_)
return !is_paused_;
- return !is_paused_ && IsVisible();
+ return !is_paused_ && (!attached_to_window_ || window_visible_);
}
gfx::Rect BrowserViewRenderer::GetScreenRect() const {
@@ -729,11 +727,8 @@ bool BrowserViewRenderer::CompositeSW(SkCanvas* canvas) {
void BrowserViewRenderer::UpdateCompositorIsActive() {
if (compositor_) {
- if (disable_page_visibility_)
- compositor_->SetIsActive(!is_paused_ &&
- (!attached_to_window_ || window_visible_));
- else
- compositor_->SetIsActive(IsClientVisible());
+ compositor_->SetIsActive(!is_paused_ &&
+ (!attached_to_window_ || window_visible_));
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698