Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1475813002: Mojo C++ bindings: support passing associated interface pointers/requests in method parameter lists… (Closed)

Created:
5 years ago by yzshen1
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@25_use_multiplex_router
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: support passing associated interface pointers/requests in method parameter lists and structs. The following will be in future CLs: - passing associated interface pointers/requests in unions, arrays, maps; - check non-nullable. BUG=546067 Committed: https://crrev.com/12432a295405b68f039a30e1411b583b5871afd4 Cr-Commit-Position: refs/heads/master@{#361760}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -70 lines) Patch
M mojo/public/cpp/bindings/associated_binding.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/array_serialization.h View 8 chunks +25 lines, -12 lines 0 comments Download
M mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/bindings_serialization.h View 1 3 chunks +35 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/bindings_serialization.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_state.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/map_serialization.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/pipe_control_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/string_serialization.h View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/string_serialization.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/array_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/tests/associated_interface_unittest.cc View 2 chunks +53 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/map_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/tests/union_unittest.cc View 16 chunks +16 lines, -16 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 6 chunks +10 lines, -8 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_proxy_declaration.tmpl View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl View 4 chunks +16 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl View 2 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (12 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks! This CL depends on https://codereview.chromium.org/1473273003/
5 years ago (2015-11-24 22:05:56 UTC) #3
sky
LGTM
5 years ago (2015-11-25 00:09:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475813002/1
5 years ago (2015-11-25 06:33:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/145995)
5 years ago (2015-11-25 06:49:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475813002/20001
5 years ago (2015-11-25 17:40:00 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/101463)
5 years ago (2015-11-25 20:25:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475813002/20001
5 years ago (2015-11-25 20:27:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475813002/20001
5 years ago (2015-11-25 21:27:02 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 00:32:05 UTC) #20
commit-bot: I haz the power
5 years ago (2015-11-26 00:33:43 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/12432a295405b68f039a30e1411b583b5871afd4
Cr-Commit-Position: refs/heads/master@{#361760}

Powered by Google App Engine
This is Rietveld 408576698