[test] Add status-file presubmit check.

[test] Add status-file presubmit check.

This loads all test suites and status files to catch subtle
syntax errors. It also checks basic status file integrity
and common mistakes.

NOTRY=true

Committed: https://crrev.com/e8bfedab96e81247b2b426d09e221b52e05c6af9
Cr-Commit-Position: refs/heads/master@{#32271}

[Michael Achenbach, 2015-11-25 08:20:41]

Description was changed from

==========
[test] Add status file presubmit check.

BUG=
==========

to

==========
[test] Add status file presubmit check.

NOTRY=true
==========

[Michael Achenbach, 2015-11-25 08:21:40]

Description was changed from

==========
[test] Add status file presubmit check.

NOTRY=true
==========

to

==========
[test] Add status-file presubmit check.

This loads all test suites and status files to catch subtle
syntax errors. It also checks basic status file integrity
and common mistakes.

NOTRY=true
==========

[Michael Achenbach, 2015-11-25 08:21:49]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 08:21:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1475663002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1475663002/1

[commit-bot: I haz the power, 2015-11-25 08:23:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 08:23:33]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2015-11-25 08:26:43]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 08:26:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1475663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1475663002/20001

[Michael Achenbach, 2015-11-25 08:28:00]

machenbach@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Michael Achenbach, 2015-11-25 08:28:00]

PTAL

[commit-bot: I haz the power, 2015-11-25 08:28:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 08:28:02]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2015-11-25 08:29:29]

Sadly we still can't detect duplicate entries with this...

[Jakob Kummerow, 2015-11-25 11:04:17]

LGTM as is, just some comments to document our offline discussion.

https://codereview.chromium.org/1475663002/diff/20001/tools/testrunner/local/...
File tools/testrunner/local/statusfile.py (right):

https://codereview.chromium.org/1475663002/diff/20001/tools/testrunner/local/...
tools/testrunner/local/statusfile.py:142: assert type(section) == list
we could consider dropping this (as presubmit checks it already), but it appears
to be fast enough that we can afford not to care about the duplication.

https://codereview.chromium.org/1475663002/diff/20001/tools/testrunner/local/...
tools/testrunner/local/statusfile.py:162: assert type(section) == list
This checker bails out on the first error it finds. That's a bit sad, as it
means for detecting and fixing several errors you have to repeat the "run
checker, fix problem, run checker again" cycle repeatedly. OTOH that's probably
a rare case, and not worth spending more engineering effort and code complexity
on.

[Michael Achenbach, 2015-11-25 13:17:28]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-11-25 13:17:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1475663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1475663002/20001

[commit-bot: I haz the power, 2015-11-25 13:18:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-25 13:19:37]

Patchset 2 (id:??) landed as
https://crrev.com/e8bfedab96e81247b2b426d09e221b52e05c6af9
Cr-Commit-Position: refs/heads/master@{#32271}