[test] Add status-file presubmit check.

tools/testrunner/local/statusfile.py

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
 #       with the distribution.
 #     * Neither the name of Google Inc. nor the names of its
 #       contributors may be used to endorse or promote products derived
 #       from this software without specific prior written permission.
 #
 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+import os
 
 # These outcomes can occur in a TestCase's outcomes list:
 SKIP = "SKIP"
 FAIL = "FAIL"
 PASS = "PASS"
 OKAY = "OKAY"
 TIMEOUT = "TIMEOUT"
 CRASH = "CRASH"
 SLOW = "SLOW"
 FLAKY = "FLAKY"
@@ skipping 80 matching lines @@
         _AddOutcome(result, outcome)
     else:
       assert False
   if len(result) == 0: return
   if rule in target_dict:
     target_dict[rule] |= result
   else:
     target_dict[rule] = result
 
 
-def ReadStatusFile(path, variables):
+def ReadContent(path):
   with open(path) as f:
     global KEYWORDS
-    contents = eval(f.read(), KEYWORDS)
+    return eval(f.read(), KEYWORDS)
+
+
+def ReadStatusFile(path, variables):
+  contents = ReadContent(path)
 
   rules = {}
   wildcards = {}
   variables.update(VARIABLES)
   for section in contents:
     assert type(section) == list

[Jakob Kummerow, 2015/11/25 11:04:17]

we could consider dropping this (as presubmit checks it already), but it appears
to be fast enough that we can afford not to care about the duplication.

     assert len(section) == 2
     if not eval(section[0], variables): continue
     section = section[1]
     assert type(section) == dict
     for rule in section:
       assert type(rule) == str
       if rule[-1] == '*':
         _ParseOutcomeList(rule, section[rule], wildcards, variables)
       else:
         _ParseOutcomeList(rule, section[rule], rules, variables)
   return rules, wildcards
+
+
+def PresubmitCheck(path):
+  contents = ReadContent(path)
+  root_prefix = os.path.basename(os.path.dirname(path)) + "/"
+
+  try:
+    for section in contents:
+      assert type(section) == list

[Jakob Kummerow, 2015/11/25 11:04:17]

This checker bails out on the first error it finds. That's a bit sad, as it
means for detecting and fixing several errors you have to repeat the "run
checker, fix problem, run checker again" cycle repeatedly. OTOH that's probably
a rare case, and not worth spending more engineering effort and code complexity
on.

+      assert len(section) == 2
+      section = section[1]
+      assert type(section) == dict
+      for rule in section:
+        assert type(rule) == str
+        assert not rule.startswith(root_prefix), (
+            "Suite name prefix must not be used in status files")
+        assert not rule.endswith('.js'), (
+            ".js extension must not be used in status files.")
+    return True
+  except Exception as e:
+    print e
+    return False