Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1475643006: Revert of List all child surfaces (including occluded) in CompositorFrame (Closed)

Created:
5 years ago by jbauman
Modified:
5 years ago
Reviewers:
danakj, kenrb
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of List all child surfaces (including occluded) in CompositorFrame (patchset #7 id:120001 of https://codereview.chromium.org/1430363002/ ) Reason for revert: Seems to have broken resize of some OOPIF. BUG=560237 Original issue's description: > List all child surfaces (including occluded) in CompositorFrame > > Then any occluded child surface with a copy request can be aggregated > (and have its copy done) whenever its parent draws. > > BUG=529378 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/915e16b393182f9ccc0ddc4caadd5f7744b25fd4 > Cr-Commit-Position: refs/heads/master@{#360896} TBR=danakj@chromium.org,kenrb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=529378 Committed: https://crrev.com/ecf13e70d29a1c640985345e933c81ba403884ec Cr-Commit-Position: refs/heads/master@{#361604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -214 lines) Patch
M cc/layers/surface_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/surface_layer_impl.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M cc/output/compositor_frame_metadata.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/quads/render_pass.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/quads/render_pass_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M cc/surfaces/surface.cc View 1 chunk +6 lines, -1 line 0 comments Download
M cc/surfaces/surface_aggregator.h View 2 chunks +1 line, -11 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 5 chunks +6 lines, -62 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M cc/surfaces/surface_factory_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M content/common/cc_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/cc_messages.cc View 5 chunks +9 lines, -0 lines 0 comments Download
M content/common/cc_messages_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbauman
Created Revert of List all child surfaces (including occluded) in CompositorFrame
5 years ago (2015-11-25 07:53:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475643006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475643006/1
5 years ago (2015-11-25 07:53:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 07:54:32 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-25 07:55:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecf13e70d29a1c640985345e933c81ba403884ec
Cr-Commit-Position: refs/heads/master@{#361604}

Powered by Google App Engine
This is Rietveld 408576698