Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5692)

Unified Diff: chrome/installer/setup/installer_crash_keys.h

Issue 1475643004: Add crash keys for the installer covering simple InstallerState fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move command-line switch refactor to another patch for easier review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/installer_crash_keys.h
diff --git a/chrome/installer/setup/installer_crash_keys.h b/chrome/installer/setup/installer_crash_keys.h
new file mode 100644
index 0000000000000000000000000000000000000000..933183a30019e709d39f32a502e2e0bc9a8efb5e
--- /dev/null
+++ b/chrome/installer/setup/installer_crash_keys.h
@@ -0,0 +1,22 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_INSTALLER_SETUP_INSTALLER_CRASH_KEYS_H_
+#define CHROME_INSTALLER_SETUP_INSTALLER_CRASH_KEYS_H_
+
grt (UTC plus 2) 2015/11/26 19:24:45 #include <vector>
Joe Mason 2015/11/26 20:49:05 Done.
+#include "base/debug/crash_logging.h"
+
+namespace installer {
+
+class InstallerState;
+
+void ConfigureCrashReporting(const InstallerState& installer_state);
grt (UTC plus 2) 2015/11/26 19:24:45 please add a doc comment for each of these (https:
Joe Mason 2015/11/26 20:49:05 Done.
+
+void RegisterCrashKeys(std::vector<base::debug::CrashKey>& keys);
grt (UTC plus 2) 2015/11/26 19:24:45 GetCrashKeys is more accurate since this doesn't a
Joe Mason 2015/11/26 20:49:05 Done.
+
+void SetStartingCrashKeys(const InstallerState& installer_state);
grt (UTC plus 2) 2015/11/26 19:24:45 nit: i prefer SetInitialCrashKeys
Joe Mason 2015/11/26 20:49:05 Done.
+
+} // namespace installer
+
+#endif // CHROME_INSTALLER_SETUP_INSTALLER_CRASH_KEYS_H_

Powered by Google App Engine
This is Rietveld 408576698