chrome/installer/setup/installer_crash_keys.h - Issue 1475643004: Add crash keys for the installer covering simple InstallerState fields.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/setup/installer_crash_keys.h

Issue 1475643004: Add crash keys for the installer covering simple InstallerState fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move command-line switch refactor to another patch for easier review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_INSTALLER_SETUP_INSTALLER_CRASH_KEYS_H_

	6 #define CHROME_INSTALLER_SETUP_INSTALLER_CRASH_KEYS_H_

	7
	grt (UTC plus 2) 2015/11/26 19:24:45 #include <vector> #include <vector> Joe Mason 2015/11/26 20:49:05 Done. Show quoted text On 2015/11/26 19:24:45, grt wrote: > #include <vector> Done.
	8 #include "base/debug/crash_logging.h"

	9

	10 namespace installer {

	11

	12 class InstallerState;

	13

	14 void ConfigureCrashReporting(const InstallerState& installer_state);
	grt (UTC plus 2) 2015/11/26 19:24:45 please add a doc comment for each of these (https: please add a doc comment for each of these (https://google.github.io/styleguide/cppguide.html#Function_Comments) Joe Mason 2015/11/26 20:49:05 Done. Show quoted text On 2015/11/26 19:24:45, grt wrote: > please add a doc comment for each of these > (https://google.github.io/styleguide/cppguide.html#Function_Comments) Done.
	15

	16 void RegisterCrashKeys(std::vector<base::debug::CrashKey>& keys);
	grt (UTC plus 2) 2015/11/26 19:24:45 GetCrashKeys is more accurate since this doesn't a GetCrashKeys is more accurate since this doesn't actually register them. Joe Mason 2015/11/26 20:49:05 Done. Show quoted text On 2015/11/26 19:24:45, grt wrote: > GetCrashKeys is more accurate since this doesn't actually register them. Done.
	17

	18 void SetStartingCrashKeys(const InstallerState& installer_state);
	grt (UTC plus 2) 2015/11/26 19:24:45 nit: i prefer SetInitialCrashKeys nit: i prefer SetInitialCrashKeys Joe Mason 2015/11/26 20:49:05 Done. Show quoted text On 2015/11/26 19:24:45, grt wrote: > nit: i prefer SetInitialCrashKeys Done.
	19

	20 } // namespace installer

	21

	22 #endif // CHROME_INSTALLER_SETUP_INSTALLER_CRASH_KEYS_H_

OLD	NEW

« no previous file with comments | « chrome/installer/setup/BUILD.gn ('k') | chrome/installer/setup/installer_crash_keys.cc » ('j') | chrome/installer/setup/installer_crash_keys.cc » ('J')