Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7954)

Unified Diff: chrome/installer/setup/setup_constants.cc

Issue 1475643004: Add crash keys for the installer covering simple InstallerState fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add previous version, plus some comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/setup_constants.cc
diff --git a/chrome/installer/setup/setup_constants.cc b/chrome/installer/setup/setup_constants.cc
index 8d705faad8100a49bf1f8cea4acc9c31b667ed2c..1cd7caa543dacb88d1b53b7d7feadc2671c8968a 100644
--- a/chrome/installer/setup/setup_constants.cc
+++ b/chrome/installer/setup/setup_constants.cc
@@ -35,4 +35,15 @@ const char kSetDisplayVersionValue[] = "set-display-version-value";
} // namespace switches
+namespace crash_keys {
+
+const char kCurrentVersion[] = "current-version";
+const char kDistributionType[] = "dist-type";
+const char kOperation[] = "operation";
+const char kPackageType[] = "package-type";
grt (UTC plus 2) 2015/11/25 16:44:09 since this is keyed off the --multi-install comman
Joe Mason 2015/11/25 17:20:48 Shouldn't we plan for expansion such as adding fur
grt (UTC plus 2) 2015/11/25 17:44:01 Yeah, about that... :-) We're working on removing
+const char kPrivilegeLevel[] = "priv-level";
grt (UTC plus 2) 2015/11/25 16:44:09 likewise, i think "system-level" with ("false", "t
+const char kStateKey[] = "state-key";
+
+} // namespace crash_keys
+
} // namespace installer

Powered by Google App Engine
This is Rietveld 408576698