Add crash keys for the installer covering simple InstallerState fields.

chrome/installer/setup/setup_constants.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/setup/setup_constants.h"
 
 namespace installer {
 
 // Elements that make up install paths.
 const wchar_t kChromeArchive[] = L"chrome.7z";
@@ skipping 17 matching lines @@
 const char kDelay[] = "delay";
 
 // Set the MSI-managed DisplayVersion in the registry to match Chrome's real
 // version number. The parameter to this option specifies the product-id in
 // the registry under HKLM.
 const char kSetDisplayVersionProduct[] = "set-display-version-product";
 const char kSetDisplayVersionValue[] = "set-display-version-value";
 
 }  // namespace switches
 
+namespace crash_keys {
+
+const char kCurrentVersion[] = "current-version";
+const char kDistributionType[] = "dist-type";
+const char kOperation[] = "operation";
+const char kPackageType[] = "package-type";

[grt (UTC plus 2), 2015/11/25 16:44:09]

since this is keyed off the --multi-install command line switch, i think
"multi-install" with values of ("false", "true") will be easier to understand on
the backend.

[Joe Mason, 2015/11/25 17:20:48]

Shouldn't we plan for expansion such as adding further package types? (I'm
following the example of the comment saying InstallerState::is_multi_install is
deprecated, so trying to map to the enum values instead of a bool.)

[grt (UTC plus 2), 2015/11/25 17:44:01]

Yeah, about that... :-) We're working on removing the concept of package types
and multi-install. There will never be more than single and multi, and multi
will go away leaving only single. When that happens we'll delete this crash key
altogether.

+const char kPrivilegeLevel[] = "priv-level";

[grt (UTC plus 2), 2015/11/25 16:44:09]

likewise, i think "system-level" with ("false", "true") is better here.

+const char kStateKey[] = "state-key";
+
+}  // namespace crash_keys
+
 }  // namespace installer