Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7230)

Unified Diff: chrome/installer/setup/installer_crash_reporter_client.cc

Issue 1475643004: Add crash keys for the installer covering simple InstallerState fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add previous version, plus some comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/installer/setup/setup_constants.h » ('j') | chrome/installer/setup/setup_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/installer_crash_reporter_client.cc
diff --git a/chrome/installer/setup/installer_crash_reporter_client.cc b/chrome/installer/setup/installer_crash_reporter_client.cc
index a19f09507a201e4f400d2e8a9808a7d3ee92a55c..f593befbf7bbc643f9ccbf63eae578c7a4649a7e 100644
--- a/chrome/installer/setup/installer_crash_reporter_client.cc
+++ b/chrome/installer/setup/installer_crash_reporter_client.cc
@@ -13,6 +13,7 @@
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_version.h"
#include "chrome/common/env_vars.h"
+#include "chrome/installer/setup/setup_constants.h"
#include "chrome/installer/util/google_update_settings.h"
#include "components/crash/core/common/crash_keys.h"
@@ -126,6 +127,17 @@ bool InstallerCrashReporterClient::GetCrashDumpLocation(
size_t InstallerCrashReporterClient::RegisterCrashKeys() {
const base::debug::CrashKey kKeys[] = {
{ crash_keys::kClientId, crash_keys::kSmallSize },
+ { installer::crash_keys::kCurrentVersion, crash_keys::kSmallSize },
+ { installer::crash_keys::kDistributionType, crash_keys::kSmallSize },
+ { installer::crash_keys::kOperation, crash_keys::kSmallSize },
+ { installer::crash_keys::kPackageType, crash_keys::kSmallSize },
+ { installer::crash_keys::kPrivilegeLevel, crash_keys::kSmallSize },
+
+ // This is a Windows registry key, which maxes out at 255 chars.
+ // (kMediumSize actually maxes out at 252 chars on Windows, but potentially
+ // truncating such a small amount is a fair tradeoff compared to using
+ // kLargeSize, which is wasteful.)
+ { installer::crash_keys::kStateKey, crash_keys::kMediumSize },
};
return base::debug::InitCrashKeys(&kKeys[0], arraysize(kKeys),
« no previous file with comments | « no previous file | chrome/installer/setup/setup_constants.h » ('j') | chrome/installer/setup/setup_constants.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698