Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1475613002: [turbofan] Introduce proper CreateLiteralParameters. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@ArrayLiteral_LiteralIndexPush
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce proper CreateLiteralParameters. Put the constant parts of the CreateLiteralArray and CreateLiteralObject operators into CreateLiteralParameters and properly use them everywhere. R=mstarzinger@chromium.org Committed: https://crrev.com/68ce906134976e688491ec1bb7e3aba7c8f29286 Cr-Commit-Position: refs/heads/master@{#32207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -47 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M src/compiler/js-operator.h View 2 chunks +32 lines, -2 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +46 lines, -8 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 4 chunks +16 lines, -7 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +25 lines, -16 lines 0 comments Download

Depends on Patchset:

Issue 1471893003 Patch 20001

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years ago (2015-11-24 12:43:38 UTC) #1
Benedikt Meurer
Hey Michi, As discussed offline, moving constant parts to dedicated parameters object. Please take a ...
5 years ago (2015-11-24 12:44:09 UTC) #2
Michael Starzinger
LGTM.
5 years ago (2015-11-24 13:39:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475613002/1
5 years ago (2015-11-24 13:40:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 13:42:18 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-24 13:42:38 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/68ce906134976e688491ec1bb7e3aba7c8f29286
Cr-Commit-Position: refs/heads/master@{#32207}

Powered by Google App Engine
This is Rietveld 408576698