[compiler] No need to push literal index in VisitArrayLiteral.

[compiler] No need to push literal index in VisitArrayLiteral.

The literal index is being pushed onto the stack while evaluating
the non-constant subexpressions, but never used in fullcodegen (and
hence not used in the optimizing compilers).

R=mstarzinger@chromium.org

Committed: https://crrev.com/9846f386f08e2aaf897851f0f54c0967c51484fb
Cr-Commit-Position: refs/heads/master@{#32205}

[Benedikt Meurer, 2015-11-24 12:11:25]

Hey Michi,

Less code is still best code, so we can even avoid dead values on the stack.
Please take a look.

Thanks,
Benedikt

[Michael Starzinger, 2015-11-24 12:29:23]

LGTM with one comment to address.

https://codereview.chromium.org/1471893003/diff/1/src/compiler/ast-graph-buil...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1471893003/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.cc:1920: // The array and the literal index are
both expected on the operand stack
nit: Comment outdated, please adapt.

[Benedikt Meurer, 2015-11-24 12:30:32]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-11-24 12:30:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1471893003/#ps20001
(title: "Comment")

[Benedikt Meurer, 2015-11-24 12:30:43]

https://codereview.chromium.org/1471893003/diff/1/src/compiler/ast-graph-buil...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1471893003/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.cc:1920: // The array and the literal index are
both expected on the operand stack
On 2015/11/24 12:29:23, Michael Starzinger wrote:
> nit: Comment outdated, please adapt.

Done.

[commit-bot: I haz the power, 2015-11-24 12:30:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471893003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471893003/20001

[commit-bot: I haz the power, 2015-11-24 13:04:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-24 13:04:43]

Patchset 2 (id:??) landed as
https://crrev.com/9846f386f08e2aaf897851f0f54c0967c51484fb
Cr-Commit-Position: refs/heads/master@{#32205}