Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: net/dns/mdns_client_impl.h

Issue 1475553002: Remove ScopedVector from CreateSockets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/mdns_client_impl.h
diff --git a/net/dns/mdns_client_impl.h b/net/dns/mdns_client_impl.h
index eb7e5e3bb98edb39c2f16859f4cff480de72ced5..e16462d2b6bdd10ae3b3860bd2ce0ca5a003cee8 100644
--- a/net/dns/mdns_client_impl.h
+++ b/net/dns/mdns_client_impl.h
@@ -13,7 +13,6 @@
#include "base/cancelable_callback.h"
#include "base/gtest_prod_util.h"
-#include "base/memory/scoped_vector.h"
#include "base/observer_list.h"
#include "net/base/io_buffer.h"
#include "net/base/ip_endpoint.h"
@@ -35,7 +34,8 @@ class MDnsSocketFactoryImpl : public MDnsSocketFactory {
MDnsSocketFactoryImpl() {}
~MDnsSocketFactoryImpl() override{};
- void CreateSockets(ScopedVector<DatagramServerSocket>* sockets) override;
+ void CreateSockets(
+ std::vector<scoped_ptr<DatagramServerSocket>>* sockets) override;
mmenke 2015/11/24 17:39:33 include scoped_ptr
private:
DISALLOW_COPY_AND_ASSIGN(MDnsSocketFactoryImpl);
@@ -97,7 +97,7 @@ class NET_EXPORT_PRIVATE MDnsConnection {
void OnError(int rv);
// Only socket handlers which successfully bound and started are kept.
- ScopedVector<SocketHandler> socket_handlers_;
+ std::vector<scoped_ptr<SocketHandler>> socket_handlers_;
Delegate* delegate_;

Powered by Google App Engine
This is Rietveld 408576698