Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/dns/mdns_client.h

Issue 1475553002: Remove ScopedVector from CreateSockets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/utility/local_discovery/service_discovery_message_handler.cc ('K') | « chrome/utility/local_discovery/service_discovery_message_handler.cc ('k') | net/dns/mdns_client_impl.h » ('j') | net/dns/mdns_client_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/mdns_client.h
diff --git a/net/dns/mdns_client.h b/net/dns/mdns_client.h
index 1c75b0465137f1828dea7651ec1d78a48ccbb66e..7b180264393a6b754fe123430e120bfef3292aa2 100644
--- a/net/dns/mdns_client.h
+++ b/net/dns/mdns_client.h
@@ -14,9 +14,6 @@
#include "net/dns/dns_response.h"
#include "net/dns/record_parsed.h"
-template <typename T>
-class ScopedVector;
-
namespace net {
class DatagramServerSocket;
@@ -131,7 +128,8 @@ class NET_EXPORT MDnsListener {
class NET_EXPORT MDnsSocketFactory {
public:
virtual ~MDnsSocketFactory() {}
- virtual void CreateSockets(ScopedVector<DatagramServerSocket>* sockets) = 0;
+ virtual void CreateSockets(
+ std::vector<scoped_ptr<DatagramServerSocket>>* sockets) = 0;
mmenke 2015/11/24 17:39:33 include scoped_ptr (Yea, should have been included
static scoped_ptr<MDnsSocketFactory> CreateDefault();
};
« chrome/utility/local_discovery/service_discovery_message_handler.cc ('K') | « chrome/utility/local_discovery/service_discovery_message_handler.cc ('k') | net/dns/mdns_client_impl.h » ('j') | net/dns/mdns_client_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698