Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1475493003: Revert of Implement xorshift128+ for Math.random. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Implement xorshift128+ for Math.random. (patchset #6 id:100001 of https://codereview.chromium.org/1464303002/ ) Reason for revert: Test failure: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/491/steps/Mjsunit/logs/reflect-own-keys Original issue's description: > Implement xorshift128+ for Math.random. > > BUG=v8:4566 > LOG=N > > Committed: https://crrev.com/2755c5a1b1cf7fc4c5c614378e5231636e6dcff5 > Cr-Commit-Position: refs/heads/master@{#32200} TBR=bmeurer@chromium.org,jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4566 Committed: https://crrev.com/be22cdafc21a9cf4b3bb78aff6ed46a2827948a1 Cr-Commit-Position: refs/heads/master@{#32202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -114 lines) Patch
M src/base/utils/random-number-generator.h View 3 chunks +5 lines, -35 lines 0 comments Download
M src/base/utils/random-number-generator.cc View 2 chunks +15 lines, -18 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/js/math.js View 2 chunks +23 lines, -17 lines 0 comments Download
M src/js/prologue.js View 3 chunks +5 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +12 lines, -42 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Implement xorshift128+ for Math.random.
5 years ago (2015-11-24 11:32:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475493003/1
5 years ago (2015-11-24 11:32:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 11:32:37 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-24 11:32:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be22cdafc21a9cf4b3bb78aff6ed46a2827948a1
Cr-Commit-Position: refs/heads/master@{#32202}

Powered by Google App Engine
This is Rietveld 408576698