Issue 1475493002: Enable MinorGCUnmodifiedWrapperVisitor in workers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1475493002: Enable MinorGCUnmodifiedWrapperVisitor in workers (Closed)

Created:
5 years ago by haraken

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

More Reviews

Description

Enable MinorGCUnmodifiedWrapperVisitor in workers Currently MinorGCUnmodifiedWrapperVisitor is disabled in workers. Consequently, hasPendingActivity is ignored and a bunch of wrappers are wrongly collected when a V8 minor GC is triggered in workers. This has caused a bunch of undeterministic crashes in workers. BUG=550632, 553769 Review URL: https://codereview.chromium.org/1450293002 Cr-Commit-Position: refs/heads/master@{#360032} (cherry picked from commit 84814a37400d1cfa6707e7bb06dddeacd492d7f2) Committed: https://chromium.googlesource.com/chromium/src/+/44fc1a4e012e9694b558a1f0cb7b73178dc1bcf6

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp	View		2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

haraken

5 years ago (2015-11-24 01:43:59 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
44fc1a4e012e9694b558a1f0cb7b73178dc1bcf6.

Expand Messages | Collapse Messages