Enable MinorGCUnmodifiedWrapperVisitor in workers

Enable MinorGCUnmodifiedWrapperVisitor in workers

Currently MinorGCUnmodifiedWrapperVisitor is disabled in workers.
Consequently, hasPendingActivity is ignored and a bunch of wrappers are wrongly collected
when a V8 minor GC is triggered in workers. This has caused a bunch of undeterministic crashes
in workers.

BUG=550632, 553769
Committed: https://crrev.com/84814a37400d1cfa6707e7bb06dddeacd492d7f2
Cr-Commit-Position: refs/heads/master@{#360032}

[haraken, 2015-11-17 04:33:36]

haraken@chromium.org changed reviewers:
+ jochen@chromium.org, mythria@chromium.org, yhirano@chromium.org

[haraken, 2015-11-17 04:33:37]

jochen, mythria: Was there any reason we disabled
MinorGCUnmodifiedWrapperVisitor in workers? If I'm not missing something, it
must be enabled.

PTAL

[jochen (gone - plz use gerrit), 2015-11-17 04:40:24]

lgtm

[haraken, 2015-11-17 05:13:22]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2015-11-17 05:13:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1450293002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1450293002/1

[commit-bot: I haz the power, 2015-11-17 05:22:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 05:22:38]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[haraken, 2015-11-17 05:26:28]

The CQ bit was checked by haraken@chromium.org

[haraken, 2015-11-17 05:26:28]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1450293002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-11-17 05:26:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1450293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1450293002/20001

[commit-bot: I haz the power, 2015-11-17 06:26:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 06:26:45]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[haraken, 2015-11-17 06:43:50]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2015-11-17 06:44:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1450293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1450293002/20001

[haraken, 2015-11-17 06:45:55]

The CQ bit was checked by haraken@chromium.org

[haraken, 2015-11-17 06:45:55]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1450293002/#ps40001
(title: " ")

[yhirano, 2015-11-17 06:46:01]

An ASSERTION fails at V8GCController.cpp:248.

[commit-bot: I haz the power, 2015-11-17 06:46:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1450293002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1450293002/40001

[haraken, 2015-11-17 06:46:52]

On 2015/11/17 06:46:01, yhirano wrote:
> An ASSERTION fails at V8GCController.cpp:248.

Yes, fixed.

[commit-bot: I haz the power, 2015-11-17 07:56:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-17 07:57:11]

Patchset 3 (id:??) landed as
https://crrev.com/84814a37400d1cfa6707e7bb06dddeacd492d7f2
Cr-Commit-Position: refs/heads/master@{#360032}

[blink-reviews, 2015-11-17 08:40:20]

I am sorry, I did not enable it for workers as well. Thanks for fixing it.

On Tue, Nov 17, 2015 at 7:57 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 3 (id:??) landed as
> https://crrev.com/84814a37400d1cfa6707e7bb06dddeacd492d7f2
> Cr-Commit-Position: refs/heads/master@{#360032}
>
> https://codereview.chromium.org/1450293002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2015-11-17 08:40:21]

I am sorry, I did not enable it for workers as well. Thanks for fixing it.

On Tue, Nov 17, 2015 at 7:57 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 3 (id:??) landed as
> https://crrev.com/84814a37400d1cfa6707e7bb06dddeacd492d7f2
> Cr-Commit-Position: refs/heads/master@{#360032}
>
> https://codereview.chromium.org/1450293002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.