Issue 1475483003: Revert of Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1475483003: Revert of Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking() (Closed)

Created:
5 years ago by Xianzhu

Modified:
5 years ago

Reviewers:
chrishtr

CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking() (patchset #1 id:1 of https://codereview.chromium.org/1469823004/ ) Reason for revert: This is incorrect. We missed setNeedsRepaint() of the PaintLayers between the object's enclosingLayer and paintInvalidationContainer's layer. Original issue's description: > Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking() > > To ensure layer is set needsRepaint(). > > BUG=536999 > TEST=scrollbars/scrollbar-added-during-drag.html etc with sync painting enabled > > Committed: https://crrev.com/4c9d4570c68eddbc58f73b1fb4f4c95614bcf9d3 > Cr-Commit-Position: refs/heads/master@{#361179} TBR=chrishtr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=536999 Committed: https://crrev.com/8b4f752251d1f204338fe4d705848b614ca5d193 Cr-Commit-Position: refs/heads/master@{#361379}

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	third_party/WebKit/Source/core/layout/LayoutObject.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Xianzhu

5 years ago (2015-11-24 17:19:22 UTC) #1

Created Revert of Call PaintLayer::setNeedsRepaint in
LayoutBoxModelObject::invalidateDisplayItemClientOnBacking()

Expand Messages | Collapse Messages