Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 1475483003: Revert of Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account. 398 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account.
399 squashingLayer->setNeedsDisplayInRect(enclosingIntRect(paintInvalida tionRect), invalidationReason); 399 squashingLayer->setNeedsDisplayInRect(enclosingIntRect(paintInvalida tionRect), invalidationReason);
400 } 400 }
401 } else { 401 } else {
402 layer()->compositedLayerMapping()->setContentsNeedDisplayInRect(r, inval idationReason); 402 layer()->compositedLayerMapping()->setContentsNeedDisplayInRect(r, inval idationReason);
403 } 403 }
404 } 404 }
405 405
406 void LayoutBoxModelObject::invalidateDisplayItemClientOnBacking(const DisplayIte mClientWrapper& displayItemClient, PaintInvalidationReason invalidationReason, c onst LayoutRect* paintInvalidationRect) const 406 void LayoutBoxModelObject::invalidateDisplayItemClientOnBacking(const DisplayIte mClientWrapper& displayItemClient, PaintInvalidationReason invalidationReason, c onst LayoutRect* paintInvalidationRect) const
407 { 407 {
408 layer()->setNeedsRepaint();
409
410 if (layer()->groupedMapping()) { 408 if (layer()->groupedMapping()) {
411 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer()) { 409 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer()) {
412 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account. 410 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account.
413 IntRect paintInvalidationRectOnSquashingLayer; 411 IntRect paintInvalidationRectOnSquashingLayer;
414 if (paintInvalidationRect) 412 if (paintInvalidationRect)
415 paintInvalidationRectOnSquashingLayer = enclosingIntRect(*paintI nvalidationRect); 413 paintInvalidationRectOnSquashingLayer = enclosingIntRect(*paintI nvalidationRect);
416 squashingLayer->invalidateDisplayItemClient(displayItemClient, inval idationReason, paintInvalidationRect ? &paintInvalidationRectOnSquashingLayer : nullptr); 414 squashingLayer->invalidateDisplayItemClient(displayItemClient, inval idationReason, paintInvalidationRect ? &paintInvalidationRectOnSquashingLayer : nullptr);
417 } 415 }
418 } else if (CompositedLayerMapping* compositedLayerMapping = layer()->composi tedLayerMapping()) { 416 } else if (CompositedLayerMapping* compositedLayerMapping = layer()->composi tedLayerMapping()) {
419 if (this->displayItemClient() != displayItemClient.displayItemClient() & & isBox() && toLayoutBox(this)->usesCompositedScrolling()) { 417 if (this->displayItemClient() != displayItemClient.displayItemClient() & & isBox() && toLayoutBox(this)->usesCompositedScrolling()) {
(...skipping 645 matching lines...) Expand 10 before | Expand all | Expand 10 after
1065 if (rootElementStyle->hasBackground()) 1063 if (rootElementStyle->hasBackground())
1066 return false; 1064 return false;
1067 1065
1068 if (node() != document().firstBodyElement()) 1066 if (node() != document().firstBodyElement())
1069 return false; 1067 return false;
1070 1068
1071 return true; 1069 return true;
1072 } 1070 }
1073 1071
1074 } // namespace blink 1072 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698