chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc - Issue 147533005: [Password Generation] Update UI to match final mocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

Issue 147533005: [Password Generation] Update UI to match final mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replace_password_generation_ui

Patch Set: Merge Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/password_generation_popup_observer.h ('K') | « chrome/browser/ui/autofill/password_generation_popup_view.cc ('k') | chrome/browser/ui/views/autofill/password_generation_popup_view_views.h » ('j') | chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

index 5e306e8fea8b956afa140ed0ffb815338c2f42f2..9c3dfdb3ce4accbe48189075719eec96186f60e6 100644

--- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

+++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

@@ -144,6 +144,13 @@ void TabAutofillManagerDelegate::UpdateAutofillPopupDataListValues(

void TabAutofillManagerDelegate::HideAutofillPopup() {

if (popup_controller_.get())

popup_controller_->Hide();

+ // Password generation popups behave in the same fashion and should also

+ // be hidden.

+ PasswordGenerationManager* generation_manager =

+ PasswordGenerationManager::FromWebContents(web_contents_);

+ if (generation_manager)

+ generation_manager->HidePopup();

}

bool TabAutofillManagerDelegate::IsAutocompleteEnabled() {