[Password Generation] Update UI to match final mocks.

chrome/browser/ui/autofill/password_generation_popup_observer.h

Index: chrome/browser/ui/autofill/password_generation_popup_observer.h
diff --git a/chrome/browser/ui/autofill/password_generation_popup_observer.h b/chrome/browser/ui/autofill/password_generation_popup_observer.h
index 07a2edbb3696ce6f31e865c7a70e2cb416fd888b..cfacb3a679f3f4417d962db589c4de1f18777276 100644
--- a/chrome/browser/ui/autofill/password_generation_popup_observer.h
+++ b/chrome/browser/ui/autofill/password_generation_popup_observer.h
@@ -10,7 +10,7 @@ namespace autofill {
 // Observer for PasswordGenerationPopup events. Currently only used for testing.
 class PasswordGenerationPopupObserver {

[Evan Stade, 2014/02/03 18:49:15]

I don't think this class is the best way to add tests because it adds too much
test-only code to production. You could either:

a) use a mock popup controller
or
b) use a mock view
or
c) use a Testing class the extends controller or view
or
d) add a class that wraps the controller or view and has friend privileges

[Garrett Casto, 2014/02/04 17:54:57]

a) and b) seem like they don't actually test what I want since I want the view
and controller to actually run. c) or d) seem better, though injection isn't
possible with the current setup. I could make a factory vends
PasswordGenerationPopupControllers and use that in the PasswordGenerationManager
instead. Does this seem reasonable?

  public:
-  virtual void OnPopupShown() = 0;
+  virtual void OnPopupShown(bool password_visible) = 0;
   virtual void OnPopupHidden() = 0;
 };