Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1475213004: Revert of Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows (Closed)

Created:
5 years ago by raymes
Modified:
5 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows (patchset #48 id:1160001 of https://codereview.chromium.org/1416133003/ ) Reason for revert: Link failure on https://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/17345/steps/compile/logs/stdio Original issue's description: > Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows > > Crashpad is always compiled into chrome and its handler is always > enabled. It only uploads in Official builds. > > On Windows, the crash handler is chrome.exe run with a > --crashpad-handler argument. This is due to concern about > incompatibilities of shipping an additional new different binary for AV, > firewalls, etc. > > Sample renderer crash/1aed2bc785e28995 > Sample browser: crash/66c822815474a5d8 > > See also http://crbug.com/427611 . > > R=mark@chromium.org,cpu@chromium.org > BUG=447073, 546288, 456193 > > Committed: https://crrev.com/aaa2ff656f9fcabcbdd9e9964e3b2bdc8f5102ed > Cr-Commit-Position: refs/heads/master@{#361742} TBR=mark@chromium.org,cpu@chromium.org,scottmg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=447073, 546288, 456193

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+682 lines, -1100 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/crashpad/crashpad/client/BUILD.gn View 2 chunks +2 lines, -7 lines 0 comments Download
D build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn View 1 chunk +0 lines, -46 lines 0 comments Download
D build/secondary/third_party/crashpad/crashpad/minidump/BUILD.gn View 1 chunk +0 lines, -65 lines 0 comments Download
D build/secondary/third_party/crashpad/crashpad/snapshot/BUILD.gn View 1 chunk +0 lines, -102 lines 0 comments Download
M build/secondary/third_party/crashpad/crashpad/third_party/getopt/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D build/secondary/third_party/crashpad/crashpad/tools/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
M build/secondary/third_party/crashpad/crashpad/util/BUILD.gn View 6 chunks +33 lines, -49 lines 0 comments Download
M chrome/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_crash_reporter_client.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/app/chrome_exe_main_win.cc View 5 chunks +1 line, -38 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 9 chunks +6 lines, -16 lines 0 comments Download
M chrome/app/main_dll_loader_win.cc View 8 chunks +29 lines, -10 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/crash_upload_list.cc View 2 chunks +10 lines, -5 lines 0 comments Download
D chrome/browser/crash_upload_list_crashpad.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/crash_upload_list_crashpad.cc View 1 chunk +0 lines, -31 lines 0 comments Download
A chrome/browser/crash_upload_list_mac.h View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/crash_upload_list_mac.cc View 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/crash_upload_list_win.h View 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/browser/crash_upload_list_win.cc View 1 chunk +88 lines, -0 lines 0 comments Download
M chrome/browser/google/google_update_settings_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_dll.gypi View 5 chunks +0 lines, -13 lines 0 comments Download
M chrome/chrome_exe.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_installer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/common/child_process_logging_win.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M components/crash.gypi View 7 chunks +34 lines, -48 lines 0 comments Download
M components/crash/content/app/BUILD.gn View 5 chunks +14 lines, -26 lines 0 comments Download
D components/crash/content/app/crashpad.h View 1 chunk +0 lines, -84 lines 0 comments Download
D components/crash/content/app/crashpad.cc View 1 chunk +0 lines, -236 lines 0 comments Download
A components/crash/content/app/crashpad_mac.h View 1 chunk +73 lines, -0 lines 0 comments Download
M components/crash/content/app/crashpad_mac.mm View 5 chunks +191 lines, -10 lines 0 comments Download
D components/crash/content/app/crashpad_win.cc View 1 chunk +0 lines, -202 lines 0 comments Download
M components/crash/content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/core/common/crash_keys.h View 1 chunk +3 lines, -6 lines 0 comments Download
M components/crash/core/common/crash_keys.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_plugin_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
raymes
5 years ago (2015-11-25 23:24:06 UTC) #1
Created Revert of Crashpad Windows: Use the Crashpad client instead of Breakpad
on Windows

Powered by Google App Engine
This is Rietveld 408576698