Finch experiments on SSL, malware, and phishing interstitials

chrome/browser/safe_browsing/safe_browsing_blocking_page.h

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
index 91edef2d35c71c7d9137c8e2b58938d236890e0d..774485da15da92ed53a7f235bcd7bee6f74fc44a 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
@@ -111,6 +111,7 @@ class SafeBrowsingBlockingPage : public content::InterstitialPageDelegate {
     SHOW,
     PROCEED,
     DONT_PROCEED,
+    ADVANCED

[agl, 2013/05/01 18:54:12]

a comma at the end of the line is typical.

This doesn't appear to fit with the style of the other elements of the enum.
Should it be "SHOW_ADVANCED"?

[felt, 2013/05/01 19:39:45]

Done.

   };
 
   // Records a user action for this interstitial, using the form
@@ -262,6 +263,9 @@ class SafeBrowsingBlockingPageV2 : public SafeBrowsingBlockingPage {
                                 const string16& description2,
                                 const string16& description3);
 
+  // For the FieldTrial.

[agl, 2013/05/01 18:54:12]

// trail_ contains the Finch trial name.

(Or whatever is actually accurate.)

[felt, 2013/05/01 19:39:45]

Done.

+  std::string trial_;
+
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingBlockingPageV2);
 };