Finch experiments on SSL, malware, and phishing interstitials

chrome/browser/safe_browsing/safe_browsing_blocking_page.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Classes for managing the SafeBrowsing interstitial pages.
 //
 // When a user is about to visit a page the SafeBrowsing system has deemed to
 // be malicious, either as malware or a phishing page, we show an interstitial
 // page with some options (go back, continue) to give the user a chance to avoid
 // the harmful page.
@@ skipping 93 matching lines @@
     return interstitial_page_;
   }
 
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBlockingPageTest, MalwareReports);
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBlockingPageV2Test, MalwareReports);
 
   enum BlockingPageEvent {
     SHOW,
     PROCEED,
     DONT_PROCEED,
+    ADVANCED

[agl, 2013/05/01 18:54:12]

a comma at the end of the line is typical.

This doesn't appear to fit with the style of the other elements of the enum.
Should it be "SHOW_ADVANCED"?

[felt, 2013/05/01 19:39:45]

Done.

   };
 
   // Records a user action for this interstitial, using the form
   // SBInterstitial[Phishing|Malware|Multiple][Show|Proceed|DontProceed].
   void RecordUserAction(BlockingPageEvent event);
 
   // Records the time it took for the user to react to the
   // interstitial.  We won't double-count if this method is called
   // multiple times.
   void RecordUserReactionTime(const std::string& command);
@@ skipping 131 matching lines @@
 
   // A helper method used by the Populate methods above used to populate common
   // fields.
   void PopulateStringDictionary(base::DictionaryValue* strings,
                                 const string16& title,
                                 const string16& headline,
                                 const string16& description1,
                                 const string16& description2,
                                 const string16& description3);
 
+  // For the FieldTrial.

[agl, 2013/05/01 18:54:12]

// trail_ contains the Finch trial name.

(Or whatever is actually accurate.)

[felt, 2013/05/01 19:39:45]

Done.

+  std::string trial_;
+
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingBlockingPageV2);
 };
 
 // Factory for creating SafeBrowsingBlockingPage.  Useful for tests.
 class SafeBrowsingBlockingPageFactory {
  public:
   virtual ~SafeBrowsingBlockingPageFactory() { }
 
   virtual SafeBrowsingBlockingPage* CreateSafeBrowsingPage(
       SafeBrowsingUIManager* ui_manager,
       content::WebContents* web_contents,
       const SafeBrowsingBlockingPage::UnsafeResourceList& unsafe_resources) = 0;
 };
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_BLOCKING_PAGE_H_