Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7416)

Unified Diff: chrome/browser/resources/ssl_roadblock.html

Issue 14752005: Finch experiments on SSL, malware, and phishing interstitials (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added Safe Browsing Field Trial Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/ssl_roadblock.html
diff --git a/chrome/browser/resources/ssl_roadblock.html b/chrome/browser/resources/ssl_roadblock.html
index 57b22f3eec113ebc8c89ae4b8bdfff3281a2c894..02cf3d58a06255706c76e5efed4c51118dfed836 100644
--- a/chrome/browser/resources/ssl_roadblock.html
+++ b/chrome/browser/resources/ssl_roadblock.html
@@ -68,6 +68,30 @@
line-height: 140%;
margin: 0 77px 6pt;
}
+
+ #trial-badguy {
+ float:right;
+ height:150px;
+ padding-left: 10px;
+ padding-right: 30px;
+ width:196px;
+ }
+
+ #trial-policeman {
+ float:right;
+ height:150px;
+ padding-left: 10px;
+ padding-right: 30px;
+ width:150px;
+ }
+
+ #trial-stoplight {
+ float:right;
+ height:150px;
+ padding-left: 20px;
+ padding-right: 30px;
+ width:60px;
+ }
.twisty {
display: inline;
@@ -160,16 +184,50 @@
});
}
+ function setupFinch() {
+ var condition = $('trial-type').innerHTML;
+ if (condition == '') {
+ return; // This is the most common case.
+ } else if (condition == 'Condition18SSLNoImages') {
+ $('roadblock-icon').style.display = 'none';
+ } else if (condition == 'Condition19SSLPoliceman') {
+ $('trial-policeman').hidden = false;
+ $('more-info-short').style.marginRight = '30px';
+ $('more-info-long').style.marginRight = '30px';
+ } else if (condition == 'Condition20SSLStoplight') {
+ $('trial-stoplight').hidden = false;
+ $('more-info-short').style.marginRight = '30px';
+ $('more-info-long').style.marginRight = '30px';
+ } else if (condition == 'Condition21SSLBadGuy') {
+ $('trial-badguy').hidden = false;
+ $('more-info-short').style.marginRight = '30px';
+ $('more-info-long').style.marginRight = '30px';
+ }
+ }
+
window.addEventListener('focus', handleFocusEvent);
document.addEventListener('DOMContentLoaded', setupEvents);
+ document.addEventListener('DOMContentLoaded', setupFinch);
</script>
</head>
<body>
<div class="box">
<div class="icon">
- <img src="ssl_roadblock_icon.png" alt="SSL Error Icon">
+ <img src="ssl_roadblock_icon.png" alt="SSL Error Icon" id="roadblock-icon">
</div>
<div class="title" i18n-content="headLine"></div>
+
+ <!-- RHS images for the field trial. -->
+ <div id="trial-badguy" hidden>
+ <img src="ssl_badguy.png" alt="Bad guy">
+ </div>
+ <div id="trial-policeman" hidden>
+ <img src="ssl_policeman.png" alt="Policeman">
+ </div>
+ <div id="trial-stoplight" hidden>
+ <img src="ssl_stoplight.png" alt="Stoplight">
+ </div>
+
<div class="main" i18n-values=".innerHTML:description;dir:textdirection"></div>
<div class="main" i18n-values=".innerHTML:reasonForNotProceeding"></div>
<div class="main">
@@ -196,6 +254,7 @@
</div>
</div>
<span id="error-type" i18n-content="errorType" hidden></span>
+ <div id="trial-type" i18n-values=".innerHTML:trialType" hidden></div>
</table>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698