Issue 147513003: Linux: Use FS magic values in magic.h in file_util::GetFileSystemType().

Issue 147513003: Linux: Use FS magic values in magic.h in file_util::GetFileSystemType(). (Closed)

Created:
6 years, 10 months ago by Lei Zhang

Modified:
6 years, 10 months ago

Reviewers:
Mostyn Bramley-Moore, awong

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Linux: Use FS magic values in magic.h in file_util::GetFileSystemType(). Note: magic.h arrived in Linux 2.6.19 over 7 years ago. If this breaks builds on very old distros, please switch to nfs_fs.h locally. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249340

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -17 lines)			Patch
	M	base/file_util_linux.cc	View		3 chunks	+17 lines, -17 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/147513003/1

6 years, 10 months ago (2014-02-06 02:35:08 UTC) #4

Mostyn Bramley-Moore

On 2014/02/06 10:41:06, I haz the power (commit-bot) wrote: > Change committed as 249340 While ...

6 years, 10 months ago (2014-02-18 13:35:29 UTC) #6

awong

6 years, 10 months ago (2014-02-18 16:44:16 UTC) #7

Message was sent while issue was closed.

On 2014/02/18 13:35:29, Mostyn Bramley-Moore wrote:
> On 2014/02/06 10:41:06, I haz the power (commit-bot) wrote:
> > Change committed as 249340
> 
> While magic.h is available on most targets, some of the newer defines aren't
> always included.  In particular:
> * BTRFS_SUPER_MAGIC
> * HUGETLBFS_MAGIC
> * TMPFS_MAGIC
> 
> Would you object to me adding some ifdefs around these?

Nope. Open a new CL and send it to Lei and I?

Expand Messages | Collapse Messages