[Refinery] Introduce TypePropagatorAnalyzer - pointer types.

syzygy/refinery/types/type_repository.h

Index: syzygy/refinery/types/type_repository.h
diff --git a/syzygy/refinery/types/type_repository.h b/syzygy/refinery/types/type_repository.h
index 1c49d294f5de963774f2ff2772a3d6faaad50f2e..858921c243d2e7279636d3a5f2dab09b803d4eb9 100644
--- a/syzygy/refinery/types/type_repository.h
+++ b/syzygy/refinery/types/type_repository.h
@@ -22,6 +22,7 @@
 #include "base/macros.h"
 #include "base/containers/hash_tables.h"
 #include "base/memory/ref_counted.h"
+#include "syzygy/pe/pe_file.h"
 
 namespace refinery {
 
@@ -36,6 +37,7 @@ class TypeRepository : public base::RefCounted<TypeRepository> {
   class Iterator;
 
   TypeRepository();
+  explicit TypeRepository(const pe::PEFile::Signature& signature);

[Sigurður Ásgeirsson, 2015/11/26 21:45:12]

I think we want to abstract the module ID to something less Windowsy. Maybe we
can just use something like

using ModuleId = std::string;

and have a central service that casts from PE signature to string?

Also, I think it probably should be mandatory to provide the string. If it takes
a separate CL, then that's fine with a TODO here?

[manzagop (departed), 2015/11/27 15:20:28]

Yes, I was thinking we'd have a Signature interface that gets factory created
based on platform specific signatures, but thought it too heavy short term.
Added TODO.
I was hesitant with the notion of including a signature in a TypeRepo because
until now nothing about the class said there needs to be a 1:1 match between a
repo and a module. Agreed going halfway about it is actually worse. Will tackle
in a follow up cl, as this one is pretty large.

Added TODO.

 
   // Retrieve a type by @p id.
   TypePtr GetType(TypeId id) const;
@@ -49,6 +51,10 @@ class TypeRepository : public base::RefCounted<TypeRepository> {
   // @returns true on success, failure typically means id is already taken.
   bool AddTypeWithId(TypePtr type, TypeId id);
 
+
+  // Get the signature for the module this type represents.
+  bool GetModuleSignature(pe::PEFile::Signature* signature);
+
   // @name Accessors.
   // @{
   size_t size() const;
@@ -60,6 +66,8 @@ class TypeRepository : public base::RefCounted<TypeRepository> {
   friend class base::RefCounted<TypeRepository>;
   ~TypeRepository();
 
+  bool is_signature_set_;
+  pe::PEFile::Signature signature_;
   base::hash_map<TypeId, TypePtr> types_;
 
   DISALLOW_COPY_AND_ASSIGN(TypeRepository);