syzygy/refinery/process_state/refinery.proto - Issue 1475083002: [Refinery] Introduce TypePropagatorAnalyzer - pointer types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: syzygy/refinery/process_state/refinery.proto

Issue 1475083002: [Refinery] Introduce TypePropagatorAnalyzer - pointer types. (Closed) Base URL: https://github.com/google/syzygy.git@master

Patch Set: Nits Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: syzygy/refinery/process_state/refinery.proto

diff --git a/syzygy/refinery/process_state/refinery.proto b/syzygy/refinery/process_state/refinery.proto

index b5b5e38a7ebe47342d59fe540ff03909c6eb25ca..9823b2478c60119a9b7113d18bb3a1ba1088d126 100644

--- a/syzygy/refinery/process_state/refinery.proto

+++ b/syzygy/refinery/process_state/refinery.proto

@@ -108,8 +108,10 @@ message HeapSnippet {

}

message TypedBlock {

- optional string data_name = 1;

- optional string type_name = 2;

+ // A module identifier within the module layer.

Sigurður Ásgeirsson 2015/11/27 14:45:31 nit: this is an unsafe change to a protobuffer. Do

manzagop (departed) 2015/11/27 15:20:28 Yup, I'm aware this is a no-no when we'll start ha

+ optional uint32 module_id = 1;

+ optional uint32 type_id = 2;

+ optional string data_name = 3;

}

// An instance of a module.