Updated cq_client

Updated cq_client

R=akuegel@chromium.org
BUG=562427
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297726

[Sergiy Byelozyorov, 2015-11-27 09:49:47]

Patchset #2 (id:20001) has been deleted

[Adrian Kuegel, 2015-11-27 10:16:12]

LGTM with nits.

https://codereview.chromium.org/1475033006/diff/40001/third_party/cq_client/R...
File third_party/cq_client/README.md (right):

https://codereview.chromium.org/1475033006/diff/40001/third_party/cq_client/R...
third_party/cq_client/README.md:11: recent golang/protobuf package. Sadly, the
latter has no tags no versions.
"no tags no versions" -> did you mean "neither tags nor versions"?

https://codereview.chromium.org/1475033006/diff/40001/third_party/cq_client/R...
third_party/cq_client/README.md:13: You can get protobuf by downloading archive
from https://github.com/google/protobuf/tree/v2.6.1,
nit: Can you put the URL in the next line please?

[Sergiy Byelozyorov, 2015-11-27 10:18:57]

https://codereview.chromium.org/1475033006/diff/40001/third_party/cq_client/R...
File third_party/cq_client/README.md (right):

https://codereview.chromium.org/1475033006/diff/40001/third_party/cq_client/R...
third_party/cq_client/README.md:11: recent golang/protobuf package. Sadly, the
latter has no tags no versions.
On 2015/11/27 10:16:11, Adrian Kuegel wrote:
> "no tags no versions" -> did you mean "neither tags nor versions"?

+tandrii: please address these comments in the source and push a new version to
depot_tools

https://codereview.chromium.org/1475033006/diff/40001/third_party/cq_client/R...
third_party/cq_client/README.md:13: You can get protobuf by downloading archive
from https://github.com/google/protobuf/tree/v2.6.1,
On 2015/11/27 10:16:12, Adrian Kuegel wrote:
> nit: Can you put the URL in the next line please?

+tandrii: please address these comments in the source and push a new version to
depot_tools

[Sergiy Byelozyorov, 2015-11-27 10:19:00]

The CQ bit was checked by sergiyb@chromium.org

[commit-bot: I haz the power, 2015-11-27 10:19:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1475033006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1475033006/40001

[commit-bot: I haz the power, 2015-11-27 10:20:44]

Description was changed from

==========
Updated cq_client

R=akuegel@chromium.org
BUG=562427
==========

to

==========
Updated cq_client

R=akuegel@chromium.org
BUG=562427

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297726
==========

[commit-bot: I haz the power, 2015-11-27 10:20:45]

Committed patchset #2 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297726

[tandrii(chromium), 2015-11-27 10:40:19]

tandrii@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2015-11-27 10:40:19]

follow up: https://codereview.chromium.org/1479983002/

FTR, please record hashes so that it's easier to debug.
Good example is:
https://chromium.googlesource.com/infra/infra/+/d958b542ef6c14612975dd0f88755...

of course, we can't include all descriptions from internal repo, but we can
include at least hashes.