Index: third_party/cq_client/README.md |
diff --git a/third_party/cq_client/README.md b/third_party/cq_client/README.md |
index f575d7495e4cd8b4281d1c165e329b95adc0c0dd..a4b06baeb7830bb5cff3230c573268f6c37876c8 100644 |
--- a/third_party/cq_client/README.md |
+++ b/third_party/cq_client/README.md |
@@ -7,7 +7,18 @@ which should only be updated as a whole using Glyco (when available, see |
The canonical version is located at `https://chrome-internal.googlesource.com/ |
infra/infra_internal/+/master/commit_queue/cq_client`. |
-To generate `cq_pb2.py` and `cq.pb.go`, please use protoc version 2.6.1: |
+You'll need to use protoc version 2.6.1 and |
+recent golang/protobuf package. Sadly, the latter has no tags no versions. |
Adrian Kuegel
2015/11/27 10:16:11
"no tags no versions" -> did you mean "neither tag
Sergiy Byelozyorov
2015/11/27 10:18:56
+tandrii: please address these comments in the sou
|
+ |
+You can get protobuf by downloading archive from https://github.com/google/protobuf/tree/v2.6.1, |
Adrian Kuegel
2015/11/27 10:16:12
nit: Can you put the URL in the next line please?
Sergiy Byelozyorov
2015/11/27 10:18:56
+tandrii: please address these comments in the sou
|
+and manually building it. As for golang compiler, if you have go configured, |
+just |
+ |
+ go get -u github.com/golang/protobuf/{proto,protoc-gen-go} |
+ |
+TODO(tandrii,sergiyb): decide how to pin the go protobuf generator. |
+ |
+To generate `cq_pb2.py` and `cq.pb.go`: |
cd commit_queue/cq_client |
protoc cq.proto --python_out $(pwd) --go_out $(pwd) |
@@ -15,3 +26,4 @@ To generate `cq_pb2.py` and `cq.pb.go`, please use protoc version 2.6.1: |
Additionally, please make sure to use proto3-compatible syntax, e.g. no default |
values, no required fields. Ideally, we should use proto3 generator already, |
however alpha version thereof is still unstable. |
+ |