Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/cq_client/README.md

Issue 1475033006: Updated cq_client (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Restore manual protobuf26 fixes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/cq_client/cq.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/cq_client/README.md
diff --git a/third_party/cq_client/README.md b/third_party/cq_client/README.md
index f575d7495e4cd8b4281d1c165e329b95adc0c0dd..a4b06baeb7830bb5cff3230c573268f6c37876c8 100644
--- a/third_party/cq_client/README.md
+++ b/third_party/cq_client/README.md
@@ -7,7 +7,18 @@ which should only be updated as a whole using Glyco (when available, see
The canonical version is located at `https://chrome-internal.googlesource.com/
infra/infra_internal/+/master/commit_queue/cq_client`.
-To generate `cq_pb2.py` and `cq.pb.go`, please use protoc version 2.6.1:
+You'll need to use protoc version 2.6.1 and
+recent golang/protobuf package. Sadly, the latter has no tags no versions.
Adrian Kuegel 2015/11/27 10:16:11 "no tags no versions" -> did you mean "neither tag
Sergiy Byelozyorov 2015/11/27 10:18:56 +tandrii: please address these comments in the sou
+
+You can get protobuf by downloading archive from https://github.com/google/protobuf/tree/v2.6.1,
Adrian Kuegel 2015/11/27 10:16:12 nit: Can you put the URL in the next line please?
Sergiy Byelozyorov 2015/11/27 10:18:56 +tandrii: please address these comments in the sou
+and manually building it. As for golang compiler, if you have go configured,
+just
+
+ go get -u github.com/golang/protobuf/{proto,protoc-gen-go}
+
+TODO(tandrii,sergiyb): decide how to pin the go protobuf generator.
+
+To generate `cq_pb2.py` and `cq.pb.go`:
cd commit_queue/cq_client
protoc cq.proto --python_out $(pwd) --go_out $(pwd)
@@ -15,3 +26,4 @@ To generate `cq_pb2.py` and `cq.pb.go`, please use protoc version 2.6.1:
Additionally, please make sure to use proto3-compatible syntax, e.g. no default
values, no required fields. Ideally, we should use proto3 generator already,
however alpha version thereof is still unstable.
+
« no previous file with comments | « no previous file | third_party/cq_client/cq.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698