Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1475023002: Oilpan: hide persisted plugin object before disposing. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: hide persisted plugin object before disposing. When clearing out the persisted plugin object, hide the object before going ahead with the disposal. This mirrors what will happen non-Oilpan. R=haraken BUG=561473 Committed: https://crrev.com/1598eab5d3e04dddd5b815c28aa68344edb7767e Cr-Commit-Position: refs/heads/master@{#361665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
sof
please take a look.
5 years ago (2015-11-25 14:05:00 UTC) #3
haraken
LGTM
5 years ago (2015-11-25 15:29:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475023002/1
5 years ago (2015-11-25 15:41:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 15:46:09 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-25 15:47:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1598eab5d3e04dddd5b815c28aa68344edb7767e
Cr-Commit-Position: refs/heads/master@{#361665}

Powered by Google App Engine
This is Rietveld 408576698