third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp - Issue 1475023002: Oilpan: hide persisted plugin object before disposing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 1475023002: Oilpan: hide persisted plugin object before disposing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

index 15d82af2929e9db8bedd87afde10ef58787f2464..52f9c00f4f41453913967507eb2907a84714e51e 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

@@ -114,8 +114,10 @@ void HTMLPlugInElement::setPersistedPluginWidget(Widget* widget)

#if ENABLE(OILPAN)

unregisterAsRenderlessIfNeeded();

registerAsRenderless(widget);

- if (m_persistedPluginWidget)

+ if (m_persistedPluginWidget) {

+ m_persistedPluginWidget->hide();

m_persistedPluginWidget->dispose();

+ }

#endif

m_persistedPluginWidget = widget;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »