build/toolchain/nacl/BUILD.gn - Issue 1474833002: Enable strip in newlib_pnacl_nonsfi toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/nacl/BUILD.gn

Issue 1474833002: Enable strip in newlib_pnacl_nonsfi toolchain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/toolchain/nacl/BUILD.gn

diff --git a/build/toolchain/nacl/BUILD.gn b/build/toolchain/nacl/BUILD.gn

index 81cb99539950aadb614d24f4174ff3a17fdfaec2..0bf3642fe49c5eeb542b09bcef157fed6760cb05 100644

--- a/build/toolchain/nacl/BUILD.gn

+++ b/build/toolchain/nacl/BUILD.gn

@@ -71,9 +71,7 @@ pnacl_toolchain("newlib_pnacl") {

pnacl_toolchain("newlib_pnacl_nonsfi") {

executable_extension = ""

- # TODO(mcgrathr): Uncomment this after pnacl-strip has been taught

- # to grok --strip-unneeded.

- #strip = "strip"

+ strip = "strip"

}

template("nacl_glibc_toolchain") {

« no previous file with comments | « no previous file | no next file » | no next file with comments »