Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: build/toolchain/nacl/BUILD.gn

Issue 1474833002: Enable strip in newlib_pnacl_nonsfi toolchain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The Native Client Authors. All rights reserved. 1 # Copyright (c) 2014 The Native Client Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sysroot.gni") 5 import("//build/config/sysroot.gni")
6 import("//build/config/nacl/config.gni") 6 import("//build/config/nacl/config.gni")
7 import("//build/toolchain/nacl_toolchain.gni") 7 import("//build/toolchain/nacl_toolchain.gni")
8 8
9 # Add the toolchain revision as a preprocessor define so that sources are 9 # Add the toolchain revision as a preprocessor define so that sources are
10 # rebuilt when a toolchain is updated. 10 # rebuilt when a toolchain is updated.
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 # turns what comes out of the linker into what you actually want to 64 # turns what comes out of the linker into what you actually want to
65 # distribute and run. PNaCl doesn't have a "strip"-like utility that 65 # distribute and run. PNaCl doesn't have a "strip"-like utility that
66 # you ever actually want to use other than pnacl-finalize, so just 66 # you ever actually want to use other than pnacl-finalize, so just
67 # make pnacl-finalize the strip tool rather than adding an additional 67 # make pnacl-finalize the strip tool rather than adding an additional
68 # step like "postlink" to run pnacl-finalize. 68 # step like "postlink" to run pnacl-finalize.
69 strip = "finalize" 69 strip = "finalize"
70 } 70 }
71 71
72 pnacl_toolchain("newlib_pnacl_nonsfi") { 72 pnacl_toolchain("newlib_pnacl_nonsfi") {
73 executable_extension = "" 73 executable_extension = ""
74 # TODO(mcgrathr): Uncomment this after pnacl-strip has been taught 74 strip = "strip"
75 # to grok --strip-unneeded.
76 #strip = "strip"
77 } 75 }
78 76
79 template("nacl_glibc_toolchain") { 77 template("nacl_glibc_toolchain") {
80 toolchain_cpu = target_name 78 toolchain_cpu = target_name
81 assert(defined(invoker.toolchain_tuple), "Must define toolchain_tuple") 79 assert(defined(invoker.toolchain_tuple), "Must define toolchain_tuple")
82 assert(defined(invoker.toolchain_package), "Must define toolchain_package") 80 assert(defined(invoker.toolchain_package), "Must define toolchain_package")
83 assert(defined(invoker.toolchain_revision), "Must define toolchain_revision") 81 assert(defined(invoker.toolchain_revision), "Must define toolchain_revision")
84 forward_variables_from(invoker, 82 forward_variables_from(invoker,
85 [ 83 [
86 "toolchain_package", 84 "toolchain_package",
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 toolchain_tuple = "i686-nacl" 230 toolchain_tuple = "i686-nacl"
233 } 231 }
234 232
235 nacl_clang_toolchains("x64") { 233 nacl_clang_toolchains("x64") {
236 toolchain_tuple = "x86_64-nacl" 234 toolchain_tuple = "x86_64-nacl"
237 } 235 }
238 236
239 nacl_clang_toolchains("arm") { 237 nacl_clang_toolchains("arm") {
240 toolchain_tuple = "arm-nacl" 238 toolchain_tuple = "arm-nacl"
241 } 239 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698