Issue 1474833002: Enable strip in newlib_pnacl_nonsfi toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1474833002: Enable strip in newlib_pnacl_nonsfi toolchain (Closed)

Created:
5 years ago by Roland McGrath

Modified:
5 years ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Petr Hosek

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Enable strip in newlib_pnacl_nonsfi toolchain Now that the PNaCl toolchain has been updated so that pnacl-strip accepts the --strip-unneeded switch, the nacl-nonsfi builds can use it. BUG= none R=dpranke@chromium.org Committed: https://crrev.com/856e261366bc19b437fec95d478fbc3c679e07db Cr-Commit-Position: refs/heads/master@{#361455}

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	build/toolchain/nacl/BUILD.gn	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474833002/1

5 years ago (2015-11-24 21:17:56 UTC) #4

commit-bot: I haz the power

5 years ago (2015-11-24 21:49:19 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/856e261366bc19b437fec95d478fbc3c679e07db
Cr-Commit-Position: refs/heads/master@{#361455}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages