Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1474763002: Revert of webgl: use immutable texture for the default FBO. (Closed)

Created:
5 years ago by dshwang
Modified:
5 years ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, vmpstr+blinkwatch_chromium.org, dshwang, jbroman, Justin Novosad, danakj, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, piman+watch_chromium.org, Stephen Chennney, rwlbuis, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of webgl: use immutable texture for the default FBO. (patchset #2 id:20001 of https://codereview.chromium.org/1449043005/ ) Reason for revert: following test is broken. WebglConformance.deqp_functional_gles3_readpixel Original issue's description: > webgl: use immutable texture for the default FBO. > > Use immutable texture for the default FBO like chromium compositor. > > In theory, it speeds up drawing speed, because immutable texture skips texture > validation on drawing call. > > In addition, immutable texture allows GL_INTEL_framebuffer_CMAA more optimization. > > BUG=557848 > TEST= > WebglConformance.conformance_renderbuffers_framebuffer_state_restoration > WebglConformance.conformance_textures_misc_texture_size_cube_maps > WebglConformance.conformance_textures_misc_texture_sub_image_cube_maps > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_byte > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_short_5_6_5 > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_byte > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_4_4_4_4 > WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_5_5_5_1 > > Committed: https://crrev.com/fb9d8e245ac84c6c0806e86e7884b4775a84b4b5 > Cr-Commit-Position: refs/heads/master@{#361335} TBR=kbr@chromium.org,adrian.belgun@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557848 Committed: https://crrev.com/39ec117eabd4b0b67fe6f004385d36c75503b30c Cr-Commit-Position: refs/heads/master@{#361368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 5 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dshwang
Created Revert of webgl: use immutable texture for the default FBO.
5 years ago (2015-11-24 16:47:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474763002/1
5 years ago (2015-11-24 16:48:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 16:49:55 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-24 16:50:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39ec117eabd4b0b67fe6f004385d36c75503b30c
Cr-Commit-Position: refs/heads/master@{#361368}

Powered by Google App Engine
This is Rietveld 408576698