Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1474543003: Revert "Add stats to distinguish android renderer crashes." (Closed)

Created:
5 years ago by Primiano Tucci (use gerrit)
Modified:
5 years ago
Reviewers:
Peter Wen, Yaron, Sami
CC:
chromium-reviews, sadrul, vmpstr+watch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add stats to distinguish android renderer crashes." This reverts commit 587e705898fd262f83acd78eef13f5858f73c4e2 (crrev.com/1447213002) Reason for the revert: broke all Android perf bots. More context in crbug.com/560813. This CL is causing a null pointer deref in the browser whenever a renderer kill is detected: Thread 0 (crashed) 0 libchrome_public.so!breakpad::CrashDumpManager::Observe [crash_dump_manager_android.cc : 194 + 0x0] Found by: given as instruction pointer in context 1 libchrome_public.so!content::NotificationServiceImpl::Notify [notification_service_impl.cc : 123 + 0xd] Found by: call frame info 2 libchrome_public.so!content::RenderProcessHostImpl::Cleanup [render_process_host_impl.cc : 1790 + 0x1] Found by: call frame info 3 libchrome_public.so!content::RenderWidgetHostImpl::~RenderWidgetHostImpl [render_widget_host_impl.cc : 257 + 0x9] Found by: call frame info 4 libchrome_public.so!content::RenderViewHostImpl::~RenderViewHostImpl [render_view_host_impl.cc : 266 + 0x5] Found by: call frame info 5 libchrome_public.so!content::RenderViewHostImpl::~RenderViewHostImpl [render_view_host_impl.cc : 277 + 0x3] Found by: call frame info 6 libchrome_public.so!content::RenderWidgetHostImpl::Destroy [render_widget_host_impl.cc : 1465 + 0x7] Found by: call frame info BUG=560813, 510327 NOTRY=TRUE TBR=skyostil@chromium.org,yfriedman@chromium.org,wnwen@chromium.org Committed: https://crrev.com/7226c82f48f15c1bc5a5269ed11feff45a810df4 Cr-Commit-Position: refs/heads/master@{#361347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -179 lines) Patch
M base/android/application_status_listener.h View 2 chunks +0 lines, -4 lines 0 comments Download
M base/android/application_status_listener.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M base/android/java/src/org/chromium/base/ApplicationStatus.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java View 4 chunks +2 lines, -45 lines 0 comments Download
M components/crash/content/browser/crash_dump_manager_android.h View 3 chunks +2 lines, -24 lines 0 comments Download
M components/crash/content/browser/crash_dump_manager_android.cc View 7 chunks +7 lines, -64 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474543003/1
5 years ago (2015-11-24 15:54:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 16:01:27 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-24 16:02:40 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7226c82f48f15c1bc5a5269ed11feff45a810df4
Cr-Commit-Position: refs/heads/master@{#361347}

Powered by Google App Engine
This is Rietveld 408576698