Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1863)

Unified Diff: components/crash/content/browser/crash_dump_manager_android.h

Issue 1474543003: Revert "Add stats to distinguish android renderer crashes." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/browser/crash_dump_manager_android.h
diff --git a/components/crash/content/browser/crash_dump_manager_android.h b/components/crash/content/browser/crash_dump_manager_android.h
index bad3fb32fadf7c673629aedecbdb209472468f48..e3f2391efe775851903cdfa88b6617599c646109 100644
--- a/components/crash/content/browser/crash_dump_manager_android.h
+++ b/components/crash/content/browser/crash_dump_manager_android.h
@@ -7,16 +7,13 @@
#include <map>
-#include "base/android/application_status_listener.h"
#include "base/files/file.h"
#include "base/files/file_path.h"
-#include "base/process/kill.h"
#include "base/process/process.h"
#include "base/synchronization/lock.h"
#include "content/public/browser/browser_child_process_observer.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
-#include "content/public/common/process_type.h"
namespace content {
class RenderProcessHost;
@@ -51,23 +48,8 @@ class CrashDumpManager : public content::BrowserChildProcessObserver,
private:
typedef std::map<int, base::FilePath> ChildProcessIDToMinidumpPath;
- // This enum is used to back a UMA histogram, and must be treated as
- // append-only.
- enum ExitStatus {
- EMPTY_MINIDUMP_WHILE_RUNNING = 0,
- EMPTY_MINIDUMP_WHILE_PAUSED = 1,
- EMPTY_MINIDUMP_WHILE_BACKGROUND = 2,
- VALID_MINIDUMP_WHILE_RUNNING = 3,
- VALID_MINIDUMP_WHILE_PAUSED = 4,
- VALID_MINIDUMP_WHILE_BACKGROUND = 5,
- COUNT = 6
- };
-
static void ProcessMinidump(const base::FilePath& minidump_path,
- base::ProcessHandle pid,
- content::ProcessType process_type,
- base::TerminationStatus exit_status,
- base::android::ApplicationState app_state);
+ base::ProcessHandle pid);
// content::BrowserChildProcessObserver implementation:
void BrowserChildProcessHostDisconnected(
@@ -82,11 +64,7 @@ class CrashDumpManager : public content::BrowserChildProcessObserver,
const content::NotificationDetails& details) override;
// Called on child process exit (including crash).
- void OnChildExit(int child_process_id,
- base::ProcessHandle pid,
- content::ProcessType process_type,
- base::TerminationStatus exit_status,
- base::android::ApplicationState app_state);
+ void OnChildExit(int child_process_id, base::ProcessHandle pid);
content::NotificationRegistrar notification_registrar_;

Powered by Google App Engine
This is Rietveld 408576698