Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 147453003: Add the perceptual difference metric to the rebaseline server (Closed)

Created:
6 years, 10 months ago by rmistry
Modified:
6 years, 10 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add the perceptual difference metric to the rebaseline server * Finds the location of the skpdiff binary. * Calculates the perceptual difference percentage using the skpdiff binary (treats -1 as 0% perceptual similarity). * Replaces the weightedDiffMeasure in view.html with perceptualDifferent. BUG=skia:2019 NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13398 Committed: http://code.google.com/p/skia/source/detail?r=13410

Patch Set 1 : Initial upload #

Patch Set 2 : Rebase #

Patch Set 3 : Check for skpdiff -1 returns #

Patch Set 4 : Fix for gm_test #

Total comments: 2

Patch Set 5 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -8 lines) Patch
M gm/rebaseline_server/imagediffdb.py View 1 2 3 4 4 chunks +42 lines, -0 lines 0 comments Download
M gm/rebaseline_server/imagediffdb_test.py View 1 3 chunks +8 lines, -5 lines 0 comments Download
M gm/rebaseline_server/results.py View 2 chunks +3 lines, -0 lines 0 comments Download
M gm/rebaseline_server/static/view.html View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/rebaseline_server/tests/outputs/expected/results_test.ResultsTest.test_gm/gm.json View 1 2 3 19 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rmistry
6 years, 10 months ago (2014-02-10 20:06:43 UTC) #1
epoger
LGTM! Thanks for doing this.
6 years, 10 months ago (2014-02-10 23:31:00 UTC) #2
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 10 months ago (2014-02-11 12:33:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rmistry@google.com/147453003/30001
6 years, 10 months ago (2014-02-11 12:33:51 UTC) #4
commit-bot: I haz the power
Change committed as 13398
6 years, 10 months ago (2014-02-11 12:34:02 UTC) #5
rmistry
A revert of this CL has been created in https://codereview.chromium.org/131453017/ by rmistry@google.com. The reason for ...
6 years, 10 months ago (2014-02-11 13:30:21 UTC) #6
rmistry
Reopened this issue. PatchSet3 and PatchSet4 contain fixes for the test failures.
6 years, 10 months ago (2014-02-11 17:44:35 UTC) #7
epoger
https://codereview.chromium.org/147453003/diff/200002/gm/rebaseline_server/imagediffdb.py File gm/rebaseline_server/imagediffdb.py (right): https://codereview.chromium.org/147453003/diff/200002/gm/rebaseline_server/imagediffdb.py#newcode129 gm/rebaseline_server/imagediffdb.py:129: if perceptual_similarity == -1: Do you think we should ...
6 years, 10 months ago (2014-02-11 17:48:50 UTC) #8
rmistry
https://codereview.chromium.org/147453003/diff/200002/gm/rebaseline_server/imagediffdb.py File gm/rebaseline_server/imagediffdb.py (right): https://codereview.chromium.org/147453003/diff/200002/gm/rebaseline_server/imagediffdb.py#newcode129 gm/rebaseline_server/imagediffdb.py:129: if perceptual_similarity == -1: On 2014/02/11 17:48:50, epoger wrote: ...
6 years, 10 months ago (2014-02-11 17:59:56 UTC) #9
epoger
lgtm
6 years, 10 months ago (2014-02-11 18:00:24 UTC) #10
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 10 months ago (2014-02-11 18:18:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rmistry@google.com/147453003/320001
6 years, 10 months ago (2014-02-11 18:18:15 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 18:21:32 UTC) #13
Message was sent while issue was closed. 
Change committed as 13410

Powered by Google App Engine
This is Rietveld 408576698