gm/rebaseline_server/static/view.html - Issue 147453003: Add the perceptual difference metric to the rebaseline server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/static/view.html

Issue 147453003: Add the perceptual difference metric to the rebaseline server (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address feedback Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gm/rebaseline_server/results.py ('k') | gm/rebaseline_server/tests/outputs/expected/results_test.ResultsTest.test_gm/gm.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gm/rebaseline_server/static/view.html

diff --git a/gm/rebaseline_server/static/view.html b/gm/rebaseline_server/static/view.html

index 79335ca861082832f5a5b98534020ee522dc8b7e..9ce3fae140e7c8e8107c6a6da46534e44798be3c 100644

--- a/gm/rebaseline_server/static/view.html

+++ b/gm/rebaseline_server/static/view.html

@@ -263,7 +263,7 @@

value="weightedDiffMeasure"

ng-checked="(sortColumn == 'weightedDiffMeasure')"

ng-click="sortResultsBy('weightedDiffMeasure')">

- difference per pixel

+ perceptual difference

<br>

<input type="range" ng-model="pixelDiffBgColorBrightness"

ng-init="pixelDiffBgColorBrightness=64; pixelDiffBgColor=brightnessStringToHexColor(pixelDiffBgColorBrightness)"

@@ -378,9 +378,9 @@

<div ng-hide="result.expectedHashDigest == result.actualHashDigest"

- title="Weighted difference measure is {{result.weightedDiffMeasure.toFixed(4)}}%. Maximum difference per channel: R={{result.maxDiffPerChannel[0]}}, G={{result.maxDiffPerChannel[1]}}, B={{result.maxDiffPerChannel[2]}}">

+ title="Perceptual difference measure is {{result.perceptualDifference.toFixed(4)}}%. Maximum difference per channel: R={{result.maxDiffPerChannel[0]}}, G={{result.maxDiffPerChannel[1]}}, B={{result.maxDiffPerChannel[2]}}">

- {{result.weightedDiffMeasure.toFixed(4)}}%

+ {{result.perceptualDifference.toFixed(4)}}%

<br/>

<a href="/static/generated-images/diffs/{{result.expectedHashDigest}}-vs-{{result.actualHashDigest}}.png" target="_blank">View Image</a><br/>