android_webview/native/aw_contents.cc - Issue 1474483004: WebView Metrics client implementation (Chromium part)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.cc

Issue 1474483004: WebView Metrics client implementation (Chromium part) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move client back to browser layer, make it a Leaky global, and some cleanup Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/aw_metrics_service_client.cc ('K') | « android_webview/native/android_webview_jni_registrar.cc ('k') | android_webview/native/aw_metrics_switch.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents.cc

diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc

index 4a829faba54b118a22fb0e754abd9afe931e9574..30f1c98878a3a3ac25f40bd59483ddf55b157738 100644

--- a/android_webview/native/aw_contents.cc

+++ b/android_webview/native/aw_contents.cc

@@ -43,6 +43,7 @@

#include "base/command_line.h"

#include "base/memory/memory_pressure_listener.h"

#include "base/message_loop/message_loop.h"

+#include "base/metrics/user_metrics_action.h"

#include "base/pickle.h"

#include "base/strings/string16.h"

#include "base/supports_user_data.h"

@@ -62,6 +63,7 @@

#include "content/public/browser/render_frame_host.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/render_view_host.h"

+#include "content/public/browser/user_metrics.h"

#include "content/public/browser/web_contents.h"

#include "content/public/common/message_port_types.h"

#include "content/public/common/renderer_preferences.h"

@@ -209,6 +211,7 @@ AwContents::AwContents(scoped_ptr<WebContents> web_contents)

InitAutofillIfNecessary(autofill_manager_delegate->GetSaveFormData());

content::SynchronousCompositor::SetClientForWebContents(

web_contents_.get(), &browser_view_renderer_);

+ content::RecordAction(base::UserMetricsAction("Reload"));

}

void AwContents::SetJavaPeers(JNIEnv* env,