android_webview/native/android_webview_jni_registrar.cc - Issue 1474483004: WebView Metrics client implementation (Chromium part)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/android_webview_jni_registrar.cc

Issue 1474483004: WebView Metrics client implementation (Chromium part) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move client back to browser layer, make it a Leaky global, and some cleanup Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/aw_metrics_service_client.cc ('K') | « android_webview/lib/main/aw_main_delegate.h ('k') | android_webview/native/aw_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/android_webview_jni_registrar.cc

diff --git a/android_webview/native/android_webview_jni_registrar.cc b/android_webview/native/android_webview_jni_registrar.cc

index 275e29b0b0d5c31194533e69ec69a9e8443d4900..e3ac1e19b91d7b5e77096d85200a287a9ed53caf 100644

--- a/android_webview/native/android_webview_jni_registrar.cc

+++ b/android_webview/native/android_webview_jni_registrar.cc

@@ -16,6 +16,7 @@

#include "android_webview/native/aw_form_database.h"

#include "android_webview/native/aw_http_auth_handler.h"

#include "android_webview/native/aw_message_port_service_impl.h"

+#include "android_webview/native/aw_metrics_switch.h"

#include "android_webview/native/aw_pdf_exporter.h"

#include "android_webview/native/aw_picture.h"

#include "android_webview/native/aw_quota_manager_bridge_impl.h"

@@ -49,6 +50,7 @@ static base::android::RegistrationMethod kWebViewRegisteredMethods[] = {

{ "AwPicture", RegisterAwPicture },

{ "AwSettings", RegisterAwSettings },

{ "AwHttpAuthHandler", RegisterAwHttpAuthHandler },

+ { "AwMetricsServiceClient", RegisterAwMetricsServiceClient },

{ "AwPdfExporter", RegisterAwPdfExporter },

{ "AwPermissionRequest", RegisterAwPermissionRequest },

{ "AwQuotaManagerBridge", RegisterAwQuotaManagerBridge },

« android_webview/browser/aw_metrics_service_client.cc ('K') | « android_webview/lib/main/aw_main_delegate.h ('k') | android_webview/native/aw_contents.cc » ('j') | no next file with comments »